added flexibility to the night theme system, removed metadata from the night themes, added night themes to the project files

P3D/P3D.vbproj

@@ -17885,6 +17885,9 @@
     <Content Include="Content\Songs\intro\johto_wild.ogg">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>
+    <Content Include="Content\Songs\intro\johto_wild_night.ogg">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </Content>
     <Content Include="Content\Songs\intro\kanto_leader.ogg">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>
@@ -18071,6 +18074,12 @@
     <Content Include="Content\Songs\johto_wild_intro.ogg">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>
+    <Content Include="Content\Songs\johto_wild_intro_night.ogg">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </Content>
+    <Content Include="Content\Songs\johto_wild_night.ogg">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </Content>
     <Content Include="Content\Songs\kanto_leader.ogg">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>

P3D/Screens/BattleIntroScreen.vb

@@ -42,8 +42,8 @@
             End If
         End If
 
-        If ShouldPlayNightTheme() Then
+        If ShouldPlayNightTheme(musicLoop) Then
-            musicLoop = Screen.Level.CurrentRegion.Split(CChar(","))(0) & "_wild_night_intro"
+            musicLoop = musicLoop & "_night"
             'musicLoop = "kanto_wild_intro"
         End If
 
@@ -65,8 +65,8 @@
                 End If
             End If
 
-            If ShouldPlayNightTheme() Then
+            If ShouldPlayNightTheme(MusicLoop) Then
-                MusicLoop = Screen.Level.CurrentRegion.Split(CChar(","))(0) & "_wild_night_intro"
+                MusicLoop = MusicLoop & "_night"
             End If
 
             If MusicManager.SongExists(MusicLoop) = False Then
@@ -615,6 +615,7 @@
         'bug catching contest
         'roaming battle
         'wild pokemon
+
         Dim fallbackLoopSong = "johto_wild"
         Dim loopSong = Screen.Level.CurrentRegion.Split(CChar(","))(0) & "_wild"
         If battleType = BattleIntroScreen.BattleType.PVP Then
@@ -625,17 +626,9 @@
         ElseIf battleType = BattleIntroScreen.BattleType.SAFARI Then
             fallbackLoopSong = "johto_wild"
             loopSong = Screen.Level.CurrentRegion.Split(CChar(","))(0) & "_wild"
-            If ShouldPlayNightTheme() Then
-                loopSong = Screen.Level.CurrentRegion.Split(CChar(","))(0) & "_wild_night"
-                fallbackLoopSong = "johto_wild_night"
-            End If
         ElseIf battleType = BattleIntroScreen.BattleType.BUG_CATCHING Then
             fallbackLoopSong = "johto_wild"
             loopSong = Screen.Level.CurrentRegion.Split(CChar(","))(0) & "_wild"
-            If ShouldPlayNightTheme() Then
-                loopSong = Screen.Level.CurrentRegion.Split(CChar(","))(0) & "_wild_night"
-                fallbackLoopSong = "johto_wild_night"
-            End If
         ElseIf battleType = BattleIntroScreen.BattleType.ROAMING Then
             If BattleSystem.BattleScreen.RoamingPokemonStorage.MusicLoop <> "" Then
                 loopSong = BattleSystem.BattleScreen.RoamingPokemonStorage.MusicLoop
@@ -643,14 +636,15 @@
         ElseIf battleType = BattleIntroScreen.BattleType.WILD Then
             fallbackLoopSong = "johto_wild"
             loopSong = Screen.Level.CurrentRegion.Split(CChar(","))(0) & "_wild"
-            If ShouldPlayNightTheme() Then
-                loopSong = Screen.Level.CurrentRegion.Split(CChar(","))(0) & "_wild_night"
-                fallbackLoopSong = "johto_wild_night"
-            End If
         Else
             Console.WriteLine("Unknown Battle Type: " & battleType)
         End If
 
+        If ShouldPlayNightTheme(loopSong) Then
+            loopSong = loopSong & "_night"
+            fallbackLoopSong = "johto_wild_night"
+        End If
+
         If MusicManager.SongExists(loopSong) = True Then
             Return loopSong
         End If
@@ -661,8 +655,8 @@
         Return startTime + duration < Date.Now
     End Function
 
-    Private Function ShouldPlayNightTheme() As Boolean
+    Private Function ShouldPlayNightTheme(dayThemeName As String) As Boolean
-        Return World.IsNight() And Screen.Level.CurrentRegion = "Johto"
+        Return World.IsNight() And MusicManager.SongExists(dayThemeName & "_night")
     End Function
 
     'Protected Overrides Sub Finalize()