2014-09-18 19:56:44 +02:00
|
|
|
#/** @file
|
|
|
|
|
#
|
|
|
|
|
# Copyright (c) 2014, Linaro Limited. All rights reserved.
|
2020-10-02 23:14:02 +02:00
|
|
|
# Copyright (c) 2020, ARM Limited. All rights reserved.
|
2014-09-18 19:56:44 +02:00
|
|
|
#
|
2019-04-04 01:03:23 +02:00
|
|
|
# SPDX-License-Identifier: BSD-2-Clause-Patent
|
2014-09-18 19:56:44 +02:00
|
|
|
#
|
|
|
|
|
#**/
|
|
|
|
|
|
|
|
|
|
[Defines]
|
|
|
|
|
DEC_SPECIFICATION = 0x00010005
|
2015-05-29 15:50:43 +02:00
|
|
|
PACKAGE_NAME = ArmVirtPkg
|
2014-09-18 19:56:44 +02:00
|
|
|
PACKAGE_GUID = A0B31216-508E-4025-BEAB-56D836C66F0A
|
|
|
|
|
PACKAGE_VERSION = 0.1
|
|
|
|
|
|
|
|
|
|
################################################################################
|
|
|
|
|
#
|
|
|
|
|
# Include Section - list of Include Paths that are provided by this package.
|
|
|
|
|
# Comments are used for Keywords and Module Types.
|
|
|
|
|
#
|
|
|
|
|
# Supported Module Types:
|
|
|
|
|
# BASE SEC PEI_CORE PEIM DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION
|
|
|
|
|
#
|
|
|
|
|
################################################################################
|
|
|
|
|
[Includes.common]
|
|
|
|
|
Include # Root include for the package
|
|
|
|
|
|
2017-11-17 14:55:17 +01:00
|
|
|
[LibraryClasses]
|
|
|
|
|
ArmVirtMemInfoLib|Include/Library/ArmVirtMemInfoLib.h
|
ArmVirtPkg: introduce FdtSerialPortAddressLib
Introduce a new library class + instance for:
- collecting serial port base addresses from the device tree,
- collecting the /chosen stdout-path serial port base address from the
device tree.
The logic is loosely based on the following functions:
- SerialPortGetBaseAddress()
[ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.c]
- PlatformPeim() [ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.c]
- GetSerialConsolePortAddress()
[ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortHookLib.c]
which are going to be converted to clients of the new library later.
Copyright notices from those other files are preserved.
The new library fixes the following warts, found by reading the existent
code:
- Neither of the three functions check whether the "reg" property exists.
(This may be implicitly checked when they compare the property size to
16.)
- GetSerialConsolePortAddress() uses ScanMem8() for locating a colon (":")
node path separator in "stdout-path", when AsciiStrStr() could work just
as fine. While ScanMem8() is likely faster, "stdout-path" is presumably
very short, and ScanMem8() introduces an extra lib class dependency
(namely BaseMemoryLib).
- If ScanMem8() fails to locate a colon in "stdout-path", then
GetSerialConsolePortAddress() re-measures the length of the whole
"stdout-path" property. This is conceptually (if not performance-wise)
disturbing, because we know the whole size of the "stdout-path" property
from the property lookup just before, so we only need to subtract the
NUL-terminator for learning the length.
- GetSerialConsolePortAddress() does not check if the first (or only) node
path inside the "stdout-path" property is empty. (Not a big deal, the
subsequent alias resolution should simply fail.)
- GetSerialConsolePortAddress() does not verify if the node path retrieved
(and potentially alias-resolved) from "stdout-path" can be located in
the device tree; it assumes it.
- Code is duplicated (of course) between SerialPortGetBaseAddress() and
PlatformPeim(), but more surprisingly, all three functions embed the
same code for verifying the "status" property of the serial port node,
and for checking and reading its "reg" property.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20231008153912.175941-2-lersek@redhat.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4577
[lersek@redhat.com: add TianoCore BZ reference]
2023-10-08 17:39:04 +02:00
|
|
|
FdtSerialPortAddressLib|Include/Library/FdtSerialPortAddressLib.h
|
2017-11-17 14:55:17 +01:00
|
|
|
|
2014-09-18 19:56:44 +02:00
|
|
|
[Guids.common]
|
2015-05-29 15:50:43 +02:00
|
|
|
gArmVirtTokenSpaceGuid = { 0x0B6F5CA7, 0x4F53, 0x445A, { 0xB7, 0x6E, 0x2E, 0x36, 0x5B, 0x80, 0x63, 0x66 } }
|
2014-09-18 20:06:22 +02:00
|
|
|
gEarlyPL011BaseAddressGuid = { 0xB199DEA9, 0xFD5C, 0x4A84, { 0x80, 0x82, 0x2F, 0x41, 0x70, 0x78, 0x03, 0x05 } }
|
2020-10-02 23:14:02 +02:00
|
|
|
gEarly16550UartBaseAddressGuid = { 0xea67ca3e, 0x1f54, 0x436b, { 0x97, 0x88, 0xd4, 0xeb, 0x29, 0xc3, 0x42, 0x67 } }
|
2022-09-25 16:53:27 +02:00
|
|
|
gArmVirtSystemMemorySizeGuid = { 0x504eccb9, 0x1bf0, 0x4420, { 0x86, 0x5d, 0xdc, 0x66, 0x06, 0xd4, 0x13, 0xbf } }
|
2014-09-18 19:56:44 +02:00
|
|
|
|
2020-02-26 20:05:08 +01:00
|
|
|
[PcdsFeatureFlag]
|
|
|
|
|
#
|
|
|
|
|
# Feature Flag PCD that defines whether TPM2 support is enabled
|
|
|
|
|
#
|
|
|
|
|
gArmVirtTokenSpaceGuid.PcdTpm2SupportEnabled|FALSE|BOOLEAN|0x00000004
|
|
|
|
|
|
2015-02-28 21:25:38 +01:00
|
|
|
[PcdsFixedAtBuild, PcdsPatchableInModule]
|
2014-09-18 19:56:44 +02:00
|
|
|
#
|
|
|
|
|
# This is the physical address where the device tree is expected to be stored
|
|
|
|
|
# upon first entry into UEFI. This needs to be a FixedAtBuild PCD, so that we
|
|
|
|
|
# can do a first pass over the device tree in the SEC phase to discover the
|
|
|
|
|
# UART base address.
|
|
|
|
|
#
|
2015-05-29 15:50:43 +02:00
|
|
|
gArmVirtTokenSpaceGuid.PcdDeviceTreeInitialBaseAddress|0x0|UINT64|0x00000001
|
2014-09-18 19:56:44 +02:00
|
|
|
|
2015-02-28 21:26:10 +01:00
|
|
|
#
|
|
|
|
|
# Padding in bytes to add to the device tree allocation, so that the DTB can
|
|
|
|
|
# be modified in place (default: 256 bytes)
|
|
|
|
|
#
|
2015-05-29 15:50:43 +02:00
|
|
|
gArmVirtTokenSpaceGuid.PcdDeviceTreeAllocationPadding|256|UINT32|0x00000002
|
2015-02-28 21:26:10 +01:00
|
|
|
|
2015-07-09 08:24:25 +02:00
|
|
|
#
|
|
|
|
|
# Binary representation of the GUID that determines the terminal type. The
|
|
|
|
|
# size must be exactly 16 bytes. The default value corresponds to
|
|
|
|
|
# EFI_VT_100_GUID.
|
|
|
|
|
#
|
|
|
|
|
gArmVirtTokenSpaceGuid.PcdTerminalTypeGuidBuffer|{0x65, 0x60, 0xA6, 0xDF, 0x19, 0xB4, 0xD3, 0x11, 0x9A, 0x2D, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D}|VOID*|0x00000007
|
2017-03-29 19:50:39 +02:00
|
|
|
|
2021-07-05 12:06:40 +02:00
|
|
|
##
|
|
|
|
|
# This is the physical address of Rsdp which is the core struct of Acpi.
|
|
|
|
|
# Cloud Hypervisor has no other way to pass Rsdp address to the guest except use a PCD.
|
|
|
|
|
#
|
|
|
|
|
gArmVirtTokenSpaceGuid.PcdCloudHvAcpiRsdpBaseAddress|0x0|UINT64|0x00000005
|
