tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg: Improved SetupBrowser handling to failed GOTO callback. 

On a failed REF_OP callback, all changed fields in the Selection should be restored.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cecil Sheng <cecil.sheng@hpe.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Samer El-Haj-Mahmoud <elhaj@hpe.com>




git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19268 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Cecil Sheng 2015-12-15 05:53:46 +00:00 committed by ydong10
parent 8ab3c094b3
commit 00d1c2a35e
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
View File

@ -2,6 +2,7 @@
Utility functions for UI presentation.
Copyright (c) 2004 - 2015, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@ -2359,6 +2360,12 @@ SetupBrowser (
mCurFakeQestId = 0;
do {
//
// Reset Status to prevent the next break from returning incorrect error status.
//
Status = EFI_SUCCESS;
//
// IFR is updated, force to reparse the IFR binary
// This check is shared by EFI_BROWSER_ACTION_FORM_CLOSE and
@ -2505,10 +2512,13 @@ SetupBrowser (
//
if (EFI_ERROR (Status)) {
//
// Cross reference will not be taken
// Cross reference will not be taken, restore all essential field
//
Selection->FormId = Selection->Form->FormId;
Selection->Handle = mCurrentHiiHandle;
CopyMem (&Selection->FormSetGuid, &mCurrentFormSetGuid, sizeof (EFI_GUID));
Selection->FormId = mCurrentFormId;
Selection->QuestionId = 0;
Selection->Action = UI_ACTION_REFRESH_FORM;
}
}