tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdePkg/UnitTestBaseLib: Add check for pointer BinData 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531

AllocatePool may fail and BinData may be invalid, check it before use.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
This commit is contained in:
Guomin Jiang 2020-03-24 09:34:20 +08:00 committed by mergify[bot]
parent 695d90b9b1
commit 090e267b5b
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
View File

@ -252,9 +252,11 @@ RfcDecodeTest(
BinSize = AsciiStrnLenS (binString, MAX_TEST_STRING_SIZE); BinSize = AsciiStrnLenS (binString, MAX_TEST_STRING_SIZE);
BinData = AllocatePool (BinSize); BinData = AllocatePool (BinSize);
Btc->BufferToFree = BinData; UT_ASSERT_NOT_NULL(BinData);
Btc->BufferToFree = BinData;
ReturnSize = BinSize; ReturnSize = BinSize;
Status = Base64Decode (b64String, b64StringLen, BinData, &ReturnSize); Status = Base64Decode (b64String, b64StringLen, BinData, &ReturnSize);
UT_ASSERT_STATUS_EQUAL (Status, Btc->ExpectedStatus); UT_ASSERT_STATUS_EQUAL (Status, Btc->ExpectedStatus);