OvmfPkg: add library class BlobVerifierLib with null implementation

BlobVerifierLib will be used to verify blobs fetching them from QEMU's
firmware config (fw_cfg) in platforms that enable such verification.

The null implementation BlobVerifierLibNull treats all blobs as valid.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ashish Kalra <ashish.kalra@amd.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457
Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
This commit is contained in:
Dov Murik 2021-07-01 12:19:35 +00:00 committed by mergify[bot]
parent a26a08dc1f
commit 0cb48007f7
4 changed files with 98 additions and 0 deletions

View File

@ -0,0 +1,38 @@
/** @file
Blob verification library
This library class allows verifiying whether blobs from external sources
(such as QEMU's firmware config) are trusted.
Copyright (C) 2021, IBM Corporation
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
#ifndef BLOB_VERIFIER_LIB_H_
#define BLOB_VERIFIER_LIB_H_
#include <Uefi/UefiBaseType.h>
#include <Base.h>
/**
Verify blob from an external source.
@param[in] BlobName The name of the blob
@param[in] Buf The data of the blob
@param[in] BufSize The size of the blob in bytes
@retval EFI_SUCCESS The blob was verified successfully.
@retval EFI_ACCESS_DENIED The blob could not be verified, and therefore
should be considered non-secure.
**/
EFI_STATUS
EFIAPI
VerifyBlob (
IN CONST CHAR16 *BlobName,
IN CONST VOID *Buf,
IN UINT32 BufSize
);
#endif

View File

@ -0,0 +1,24 @@
## @file
#
# Null implementation of the blob verifier library.
#
# Copyright (C) 2021, IBM Corp
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
[Defines]
INF_VERSION = 1.29
BASE_NAME = BlobVerifierLibNull
FILE_GUID = b1b5533e-e01a-43bb-9e54-414f00ca036e
MODULE_TYPE = BASE
VERSION_STRING = 1.0
LIBRARY_CLASS = BlobVerifierLib
[Sources]
BlobVerifierNull.c
[Packages]
MdePkg/MdePkg.dec
OvmfPkg/OvmfPkg.dec

View File

@ -0,0 +1,33 @@
/** @file
Null implementation of the blob verifier library.
Copyright (C) 2021, IBM Corporation
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
#include <Library/BaseLib.h>
#include <Library/BlobVerifierLib.h>
/**
Verify blob from an external source.
@param[in] BlobName The name of the blob
@param[in] Buf The data of the blob
@param[in] BufSize The size of the blob in bytes
@retval EFI_SUCCESS The blob was verified successfully.
@retval EFI_ACCESS_DENIED The blob could not be verified, and therefore
should be considered non-secure.
**/
EFI_STATUS
EFIAPI
VerifyBlob (
IN CONST CHAR16 *BlobName,
IN CONST VOID *Buf,
IN UINT32 BufSize
)
{
return EFI_SUCCESS;
}

View File

@ -23,6 +23,9 @@
## @libraryclass Access bhyve's firmware control interface.
BhyveFwCtlLib|Include/Library/BhyveFwCtlLib.h
## @libraryclass Verify blobs read from the VMM
BlobVerifierLib|Include/Library/BlobVerifierLib.h
## @libraryclass Loads and boots a Linux kernel image
#
LoadLinuxLib|Include/Library/LoadLinuxLib.h