tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/SNP: remove redundant DEBUG print in SNP Transmit.c 

This patch is to remove some redundant DEBUG output in SNP transmit function.
In case of return EFI_NOT_READY in PxeTransmit, the SNP driver is indicate
the caller that the transmit queue is full, it's a very common situation druing
transmit, not a critical error. So the patch move the DEBUG lever to EFI_D_NET.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
This commit is contained in:
Fu Siyuan 2017-11-15 11:11:20 +08:00
parent 19bd133562
commit 0d07a8addb
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
MdeModulePkg/Universal/Network/SnpDxe/Transmit.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
Implementation of transmitting a packet. Implementation of transmitting a packet.
Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR> Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are licensed This program and the accompanying materials are licensed
and made available under the terms and conditions of the BSD License which and made available under the terms and conditions of the BSD License which
accompanies this distribution. The full text of the license may be found at accompanies this distribution. The full text of the license may be found at
@ -186,7 +186,6 @@ PxeTransmit (
(*Snp->IssueUndi32Command) ((UINT64) (UINTN) &Snp->Cdb); (*Snp->IssueUndi32Command) ((UINT64) (UINTN) &Snp->Cdb);
DEBUG ((EFI_D_NET, "\nexit Snp->undi.transmit() ")); DEBUG ((EFI_D_NET, "\nexit Snp->undi.transmit() "));
DEBUG ((EFI_D_NET, "\nSnp->Cdb.StatCode == %r", Snp->Cdb.StatCode));
// //
// we will unmap the buffers in get_status call, not here // we will unmap the buffers in get_status call, not here
@ -199,19 +198,24 @@ PxeTransmit (
case PXE_STATCODE_QUEUE_FULL: case PXE_STATCODE_QUEUE_FULL:
case PXE_STATCODE_BUSY: case PXE_STATCODE_BUSY:
Status = EFI_NOT_READY; Status = EFI_NOT_READY;
DEBUG (
(EFI_D_NET,
"\nSnp->undi.transmit() %xh:%xh\n",
Snp->Cdb.StatFlags,
Snp->Cdb.StatCode)
);
break; break;
default: default:
DEBUG (
(EFI_D_ERROR,
"\nSnp->undi.transmit() %xh:%xh\n",
Snp->Cdb.StatFlags,
Snp->Cdb.StatCode)
);
Status = EFI_DEVICE_ERROR; Status = EFI_DEVICE_ERROR;
} }
DEBUG (
(EFI_D_ERROR,
"\nSnp->undi.transmit() %xh:%xh\n",
Snp->Cdb.StatFlags,
Snp->Cdb.StatCode)
);
return Status; return Status;
} }