tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-23 05:34:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

NetworkPkg/IScsiDxe: Enhance the check for array boundary

Browse Source 
Array 'TargetUrl' of size 255 may use index value(s) 255 and 256.
So enhance the boundary check to ensure the index is valid.

Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
This commit is contained in:
Shenglei Zhang 2020-04-24 17:11:07 +08:00 committed by mergify[bot]
parent c5c5c980db
commit 0f1946b662
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NetworkPkg/IScsiDxe/IScsiDhcp.c
View File

@ -122,7 +122,7 @@ IScsiDhcpExtractRootPath (
// //
if ((!NET_IS_DIGIT (*(Field->Str))) && (*(Field->Str) != '[')) { if ((!NET_IS_DIGIT (*(Field->Str))) && (*(Field->Str) != '[')) {
ConfigNvData->DnsMode = TRUE; ConfigNvData->DnsMode = TRUE;
if (Field->Len > sizeof (ConfigNvData->TargetUrl)) { if ((Field->Len + 2) > sizeof (ConfigNvData->TargetUrl)) {
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
} }
CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len); CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);

2
NetworkPkg/IScsiDxe/IScsiDhcp6.c
View File

@ -161,7 +161,7 @@ IScsiDhcp6ExtractRootPath (
// Server name is expressed as domain name, just save it. // Server name is expressed as domain name, just save it.
// //
if (ConfigNvData->DnsMode) { if (ConfigNvData->DnsMode) {
if (Field->Len > sizeof (ConfigNvData->TargetUrl)) { if ((Field->Len + 2) > sizeof (ConfigNvData->TargetUrl)) {
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
} }
CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len); CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);