tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

EmbeddedPkg/AndroidFastbootTransportTcpDxe: remove broken hostname handling 

The fastboot TCP connection setup routine retrieves a hostname from a
UEFI variable 'hostname' that is scoped under a GUID gEfiHostnameVariableGuid
whose definition is missing from the code. Since the hostname is only printed
and then discarded, let's just drop the whole thing.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
This commit is contained in:
Ard Biesheuvel 2016-10-24 17:39:10 +01:00
parent 5e6676302b
commit 0fe2196f8b
2 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c
View File

@ -27,8 +27,6 @@
#include <Library/UefiDriverEntryPoint.h> #include <Library/UefiDriverEntryPoint.h>
#include <Library/UefiRuntimeServicesTableLib.h> #include <Library/UefiRuntimeServicesTableLib.h>
#include <Guid/Hostname.h>
#define IP4_ADDR_TO_STRING(IpAddr, IpAddrString) UnicodeSPrint ( \ #define IP4_ADDR_TO_STRING(IpAddr, IpAddrString) UnicodeSPrint ( \
IpAddrString, \ IpAddrString, \
16 * 2, \ 16 * 2, \
@ -307,9 +305,6 @@ TcpFastbootTransportStart (
EFI_HANDLE *HandleBuffer; EFI_HANDLE *HandleBuffer;
EFI_IP4_MODE_DATA Ip4ModeData; EFI_IP4_MODE_DATA Ip4ModeData;
UINTN NumHandles; UINTN NumHandles;
UINTN HostnameSize = 256;
CHAR8 Hostname[256];
CHAR16 HostnameUnicode[256] = L"<no hostname>";
CHAR16 IpAddrString[16]; CHAR16 IpAddrString[16];
UINTN Index; UINTN Index;
@ -442,28 +437,10 @@ TcpFastbootTransportStart (
// //
IP4_ADDR_TO_STRING (Ip4ModeData.ConfigData.StationAddress, IpAddrString); IP4_ADDR_TO_STRING (Ip4ModeData.ConfigData.StationAddress, IpAddrString);
// Look up hostname
Status = gRT->GetVariable (
L"Hostname",
&gEfiHostnameVariableGuid,
NULL,
&HostnameSize,
&Hostname
);
if (!EFI_ERROR (Status) && HostnameSize != 0) {
AsciiStrToUnicodeStr (Hostname, HostnameUnicode);
}
// Hostname variable is not null-terminated.
Hostname[HostnameSize] = L'\0';
mTextOut->OutputString (mTextOut, L"TCP Fastboot transport configured."); mTextOut->OutputString (mTextOut, L"TCP Fastboot transport configured.");
mTextOut->OutputString (mTextOut, L"\r\nIP address: "); mTextOut->OutputString (mTextOut, L"\r\nIP address: ");
mTextOut->OutputString (mTextOut ,IpAddrString); mTextOut->OutputString (mTextOut ,IpAddrString);
mTextOut->OutputString (mTextOut, L"\r\n"); mTextOut->OutputString (mTextOut, L"\r\n");
mTextOut->OutputString (mTextOut, L"\r\nhostname: ");
mTextOut->OutputString (mTextOut, HostnameUnicode);
mTextOut->OutputString (mTextOut, L"\r\n");
// //
// Start listening for a connection // Start listening for a connection

3
EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcpDxe.inf
View File

@ -47,8 +47,5 @@
MdeModulePkg/MdeModulePkg.dec MdeModulePkg/MdeModulePkg.dec
EmbeddedPkg/EmbeddedPkg.dec EmbeddedPkg/EmbeddedPkg.dec
[Guids]
gEfiHostnameVariableGuid
[FixedPcd] [FixedPcd]
gEmbeddedTokenSpaceGuid.PcdAndroidFastbootTcpPort gEmbeddedTokenSpaceGuid.PcdAndroidFastbootTcpPort