tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg DxeSmmPerformanceLib: Cover no SMM performance data case. 

1. Continue to get performance data by Performance Protocol
when no SMM performance data found.
2. Not try to get SMM performance data again
if no SMM performance handler found.
3. Correct typo 'totol' and 'guage'.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17561 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Star Zeng 2015-06-04 13:16:18 +00:00 committed by lzeng14
parent a9efdcc3dc
commit 11948471ad
1 changed files with 40 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmmPerformanceLib.c
View File

@ -41,6 +41,9 @@ UINTN mGaugeNumberOfEntries = 0;
GAUGE_DATA_ENTRY_EX *mGaugeDataEx = NULL; GAUGE_DATA_ENTRY_EX *mGaugeDataEx = NULL;
UINTN mGaugeNumberOfEntriesEx = 0; UINTN mGaugeNumberOfEntriesEx = 0;
BOOLEAN mNoSmmPerfHandler = FALSE;
BOOLEAN mNoSmmPerfExHandler = FALSE;
// //
// The cached Performance Protocol and PerformanceEx Protocol interface. // The cached Performance Protocol and PerformanceEx Protocol interface.
// //
@ -372,7 +375,7 @@ GetByPerformanceProtocol (
On exit, the key of the next performance log entry. On exit, the key of the next performance log entry.
@retval !NULL Get all gauge data success. @retval !NULL Get all gauge data success.
@retval NULL Get all guage data failed. @retval NULL Get all gauge data failed.
**/ **/
GAUGE_DATA_ENTRY * GAUGE_DATA_ENTRY *
EFIAPI EFIAPI
@ -386,13 +389,21 @@ GetAllSmmGaugeData (
UINTN CommSize; UINTN CommSize;
UINTN DataSize; UINTN DataSize;
if (mNoSmmPerfHandler) {
//
// Not try to get the SMM gauge data again
// if no SMM Performance handler found.
//
return NULL;
}
if (LogEntryKey != 0) { if (LogEntryKey != 0) {
if (mGaugeData != NULL) { if (mGaugeData != NULL) {
return mGaugeData; return mGaugeData;
} }
} else { } else {
// //
// Reget the SMM guage data at the first entry get. // Reget the SMM gauge data at the first entry get.
// //
if (mGaugeData != NULL) { if (mGaugeData != NULL) {
FreePool (mGaugeData); FreePool (mGaugeData);
@ -418,10 +429,13 @@ GetAllSmmGaugeData (
CommSize = SMM_PERFORMANCE_COMMUNICATION_BUFFER_SIZE; CommSize = SMM_PERFORMANCE_COMMUNICATION_BUFFER_SIZE;
// //
// Get totol number of SMM gauge entries // Get total number of SMM gauge entries
// //
SmmPerfCommData->Function = SMM_PERF_FUNCTION_GET_GAUGE_ENTRY_NUMBER; SmmPerfCommData->Function = SMM_PERF_FUNCTION_GET_GAUGE_ENTRY_NUMBER;
Status = mSmmCommunication->Communicate (mSmmCommunication, mSmmPerformanceBuffer, &CommSize); Status = mSmmCommunication->Communicate (mSmmCommunication, mSmmPerformanceBuffer, &CommSize);
if (Status == EFI_NOT_FOUND) {
mNoSmmPerfHandler = TRUE;
}
if (EFI_ERROR (Status) || EFI_ERROR (SmmPerfCommData->ReturnStatus) || SmmPerfCommData->NumberOfEntries == 0) { if (EFI_ERROR (Status) || EFI_ERROR (SmmPerfCommData->ReturnStatus) || SmmPerfCommData->NumberOfEntries == 0) {
return NULL; return NULL;
} }
@ -459,7 +473,7 @@ GetAllSmmGaugeData (
On exit, the key of the next performance log entry. On exit, the key of the next performance log entry.
@retval !NULL Get all gauge data success. @retval !NULL Get all gauge data success.
@retval NULL Get all guage data failed. @retval NULL Get all gauge data failed.
**/ **/
GAUGE_DATA_ENTRY_EX * GAUGE_DATA_ENTRY_EX *
EFIAPI EFIAPI
@ -473,13 +487,21 @@ GetAllSmmGaugeDataEx (
UINTN CommSize; UINTN CommSize;
UINTN DataSize; UINTN DataSize;
if (mNoSmmPerfExHandler) {
//
// Not try to get the SMM gauge data again
// if no SMM PerformanceEx handler found.
//
return NULL;
}
if (LogEntryKey != 0) { if (LogEntryKey != 0) {
if (mGaugeDataEx != NULL) { if (mGaugeDataEx != NULL) {
return mGaugeDataEx; return mGaugeDataEx;
} }
} else { } else {
// //
// Reget the SMM guage data at the first entry get. // Reget the SMM gauge data at the first entry get.
// //
if (mGaugeDataEx != NULL) { if (mGaugeDataEx != NULL) {
FreePool (mGaugeDataEx); FreePool (mGaugeDataEx);
@ -505,10 +527,13 @@ GetAllSmmGaugeDataEx (
CommSize = SMM_PERFORMANCE_COMMUNICATION_BUFFER_SIZE; CommSize = SMM_PERFORMANCE_COMMUNICATION_BUFFER_SIZE;
// //
// Get totol number of SMM gauge entries // Get total number of SMM gauge entries
// //
SmmPerfCommData->Function = SMM_PERF_FUNCTION_GET_GAUGE_ENTRY_NUMBER; SmmPerfCommData->Function = SMM_PERF_FUNCTION_GET_GAUGE_ENTRY_NUMBER;
Status = mSmmCommunication->Communicate (mSmmCommunication, mSmmPerformanceBuffer, &CommSize); Status = mSmmCommunication->Communicate (mSmmCommunication, mSmmPerformanceBuffer, &CommSize);
if (Status == EFI_NOT_FOUND) {
mNoSmmPerfExHandler = TRUE;
}
if (EFI_ERROR (Status) || EFI_ERROR (SmmPerfCommData->ReturnStatus) || SmmPerfCommData->NumberOfEntries == 0) { if (EFI_ERROR (Status) || EFI_ERROR (SmmPerfCommData->ReturnStatus) || SmmPerfCommData->NumberOfEntries == 0) {
return NULL; return NULL;
} }
@ -658,7 +683,15 @@ GetPerformanceMeasurementEx (
GaugeData = (GAUGE_DATA_ENTRY_EX *) &mGaugeData[LogEntryKey++]; GaugeData = (GAUGE_DATA_ENTRY_EX *) &mGaugeData[LogEntryKey++];
*Identifier = 0; *Identifier = 0;
} else { } else {
return 0; return GetByPerformanceProtocol (
LogEntryKey,
Handle,
Token,
Module,
StartTimeStamp,
EndTimeStamp,
Identifier
);
} }
} }