tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-21 12:44:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/EbcDebugger: Add check for invalid 'CommandArg'

Browse Source 
Add checks for the return value of function Atoi() in EdbCmdBreakpoint.c.
If the input parameter 'CommandArg' contains non-digit character, print
corresponding error message.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
This commit is contained in:
Hao Wu 2016-11-24 10:26:06 +08:00
parent 0978bd0dc1
commit 12f49354e6
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdBreakpoint.c
View File

@ -1,6 +1,6 @@
/*++ /*++
Copyright (c) 2007, Intel Corporation Copyright (c) 2007 - 2016, Intel Corporation
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -461,6 +461,10 @@ Returns:
// Get breakpoint index // Get breakpoint index
// //
Index = Atoi(CommandArg); Index = Atoi(CommandArg);
if (Index == (UINTN) -1) {
EDBPrint (L"BreakpointClear Argument error!\n");
return EFI_DEBUG_CONTINUE;
}
if ((Index >= EFI_DEBUGGER_BREAKPOINT_MAX) || if ((Index >= EFI_DEBUGGER_BREAKPOINT_MAX) ||
(Index >= DebuggerPrivate->DebuggerBreakpointCount)) { (Index >= DebuggerPrivate->DebuggerBreakpointCount)) {
@ -534,6 +538,10 @@ Returns:
// Get breakpoint index // Get breakpoint index
// //
Index = Atoi(CommandArg); Index = Atoi(CommandArg);
if (Index == (UINTN) -1) {
EDBPrint (L"BreakpointDisable Argument error!\n");
return EFI_DEBUG_CONTINUE;
}
// //
// Disable breakpoint // Disable breakpoint
@ -598,6 +606,10 @@ Returns:
// Get breakpoint index // Get breakpoint index
// //
Index = Atoi(CommandArg); Index = Atoi(CommandArg);
if (Index == (UINTN) -1) {
EDBPrint (L"BreakpointEnable Argument error!\n");
return EFI_DEBUG_CONTINUE;
}
// //
// Enable breakpoint // Enable breakpoint