tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-04-08 17:05:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

RedfishPkg/RedfishHttpDxe: add status code check for modification request

Browse Source 
Add HTTP status code check for POST, PUT, PATCH and DELETE Redfish
request. When status code is not expected, return failure to caller.
The expected HTTP status code is defined in Redfish specification.

Signed-off-by: Nickle Wang <nicklew@nvidia.com>
This commit is contained in:
Nickle Wang 2024-08-02 10:22:31 +08:00 committed by mergify[bot]
parent 2fe9b6c22f
commit 14e6c48103
1 changed files with 65 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.c
View File

@ -92,6 +92,67 @@ RedfishRetryRequired (
return FALSE;
}
/**
This function follows below sections in Redfish specification to
check HTTP status code and see if this is success response or not.
7.5.2 Modification success responses
7.11 POST (action)
@param[in] Method HTTP method of this status code.
@param[in] StatusCode HTTP status code.
@retval BOOLEAN Return true when this is success response.
Return false when this is not success response.
**/
BOOLEAN
RedfishSuccessResponse (
IN EFI_HTTP_METHOD Method,
IN EFI_HTTP_STATUS_CODE *StatusCode
)
{
BOOLEAN SuccessResponse;
if (StatusCode == NULL) {
return TRUE;
}
SuccessResponse = FALSE;
switch (Method) {
case HttpMethodPost:
if ((*StatusCode == HTTP_STATUS_200_OK) ||
(*StatusCode == HTTP_STATUS_201_CREATED) ||
(*StatusCode == HTTP_STATUS_202_ACCEPTED) ||
(*StatusCode == HTTP_STATUS_204_NO_CONTENT))
{
SuccessResponse = TRUE;
}
break;
case HttpMethodPatch:
case HttpMethodPut:
case HttpMethodDelete:
if ((*StatusCode == HTTP_STATUS_200_OK) ||
(*StatusCode == HTTP_STATUS_202_ACCEPTED) ||
(*StatusCode == HTTP_STATUS_204_NO_CONTENT))
{
SuccessResponse = TRUE;
}
break;
default:
//
// Return true for unsupported method to prevent false alarm.
//
SuccessResponse = TRUE;
break;
}
return SuccessResponse;
}
/**
Convert Unicode string to ASCII string. It's call responsibility to release returned buffer.
@ -824,7 +885,7 @@ RedfishPatchResource (
DEBUG ((REDFISH_HTTP_CACHE_DEBUG, "%a: Resource is updated, expire URI: %s\n", __func__, Uri));
RedfishExpireResponse (This, Uri);
if (EFI_ERROR (Status)) {
if (EFI_ERROR (Status) || !RedfishSuccessResponse (HttpMethodPatch, Response->StatusCode)) {
DEBUG_CODE (
DumpRedfishResponse (NULL, DEBUG_ERROR, Response);
);
@ -941,7 +1002,7 @@ RedfishPutResource (
DEBUG ((REDFISH_HTTP_CACHE_DEBUG, "%a: Resource is updated, expire URI: %s\n", __func__, Uri));
RedfishExpireResponse (This, Uri);
if (EFI_ERROR (Status)) {
if (EFI_ERROR (Status) || !RedfishSuccessResponse (HttpMethodPut, Response->StatusCode)) {
DEBUG_CODE (
DumpRedfishResponse (NULL, DEBUG_ERROR, Response);
);
@ -1058,7 +1119,7 @@ RedfishPostResource (
DEBUG ((REDFISH_HTTP_CACHE_DEBUG, "%a: Resource is updated, expire URI: %s\n", __func__, Uri));
RedfishExpireResponse (This, Uri);
if (EFI_ERROR (Status)) {
if (EFI_ERROR (Status) || !RedfishSuccessResponse (HttpMethodPost, Response->StatusCode)) {
DEBUG_CODE (
DumpRedfishResponse (NULL, DEBUG_ERROR, Response);
);
@ -1177,7 +1238,7 @@ RedfishDeleteResource (
DEBUG ((REDFISH_HTTP_CACHE_DEBUG, "%a: Resource is updated, expire URI: %s\n", __func__, Uri));
RedfishExpireResponse (This, Uri);
if (EFI_ERROR (Status)) {
if (EFI_ERROR (Status) || !RedfishSuccessResponse (HttpMethodDelete, Response->StatusCode)) {
DEBUG_CODE (
DumpRedfishResponse (NULL, DEBUG_ERROR, Response);
);