From 19ce77c3e90fbc5a9029163ef2813592127c4498 Mon Sep 17 00:00:00 2001 From: klu2 Date: Mon, 8 May 2006 03:34:21 +0000 Subject: [PATCH] It is legal that same base name exist in one FPD file. In future, we should use "Guid, Version, Package" and "Arch" to differ a module. So currently, warning should be disabled. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@108 6f19259b-4bc3-4df7-8a09-765794883524 --- .../build/pcd/action/CollectPCDAction.java | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/Tools/Source/GenBuild/org/tianocore/build/pcd/action/CollectPCDAction.java b/Tools/Source/GenBuild/org/tianocore/build/pcd/action/CollectPCDAction.java index 9929005872..71a30b67ab 100644 --- a/Tools/Source/GenBuild/org/tianocore/build/pcd/action/CollectPCDAction.java +++ b/Tools/Source/GenBuild/org/tianocore/build/pcd/action/CollectPCDAction.java @@ -373,15 +373,13 @@ public class CollectPCDAction { if(Token.PCD_USAGE.UNKNOWN != token.isUsageInstanceExist(moduleName)) { // - // BUGBUG: It should *not* throw exception here. Becaues in MdePkg.fpd, - // more than on BaseLib exist. But why? need confirmation. + // BUGBUG: It is legal that same base name exist in one FPD file. In furture + // we should use "Guid, Version, Package" and "Arch" to differ a module. + // So currently, warning should be disabled. // - //throw new EntityException( - // "In module " + moduleName + " exist more than one PCD token " + token.cName - // ); - ActionMessage.warning(this, - "In module " + moduleName + " exist more than one PCD token " + token.cName - ); + //ActionMessage.warning(this, + // "In module " + moduleName + " exist more than one PCD token " + token.cName + // ); return null; }