Minor code enhancement.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9692 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
xli24 2010-01-08 04:10:38 +00:00
parent e285199897
commit 1ace000135
6 changed files with 13 additions and 8 deletions

View File

@ -1,7 +1,7 @@
/** @file /** @file
Serial driver for standard UARTS on an ISA bus. Serial driver for standard UARTS on an ISA bus.
Copyright (c) 2006 - 2009, Intel Corporation<BR> Copyright (c) 2006 - 2010, Intel Corporation<BR>
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -361,7 +361,7 @@ SerialControllerDriverStart (
Status = EFI_ALREADY_STARTED; Status = EFI_ALREADY_STARTED;
for (Index = 0; Index < EntryCount; Index++) { for (Index = 0; Index < EntryCount; Index++) {
if (OpenInfoBuffer[Index].Attributes & EFI_OPEN_PROTOCOL_BY_CHILD_CONTROLLER) { if ((OpenInfoBuffer[Index].Attributes & EFI_OPEN_PROTOCOL_BY_CHILD_CONTROLLER) != 0) {
Status = gBS->OpenProtocol ( Status = gBS->OpenProtocol (
OpenInfoBuffer[Index].ControllerHandle, OpenInfoBuffer[Index].ControllerHandle,
&gEfiSerialIoProtocolGuid, &gEfiSerialIoProtocolGuid,

View File

@ -3,7 +3,7 @@
# #
# This file is used to build all modules in IntelFrameworkModulePkg. # This file is used to build all modules in IntelFrameworkModulePkg.
# #
# Copyright (c) 2007 - 2009, Intel Corporation # Copyright (c) 2007 - 2010, Intel Corporation
# #
# All rights reserved. This program and the accompanying materials # All rights reserved. This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License # are licensed and made available under the terms and conditions of the BSD License
@ -146,7 +146,6 @@
gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask|0 gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask|0
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000
gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|320 gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|320
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase|0xFFFB0000
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200 gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits|8 gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits|8
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|1 gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|1

View File

@ -1,7 +1,7 @@
/** @file /** @file
BDS Lib functions which relate with create or process the boot option. BDS Lib functions which relate with create or process the boot option.
Copyright (c) 2004 - 2009, Intel Corporation. <BR> Copyright (c) 2004 - 2010, Intel Corporation. <BR>
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -290,6 +290,7 @@ BdsLibBootViaBootOption (
BufferSize = StrSize(BootStringNumber); BufferSize = StrSize(BootStringNumber);
BufferSize += StrSize(HiiString); BufferSize += StrSize(HiiString);
Option->Description = AllocateZeroPool(BufferSize); Option->Description = AllocateZeroPool(BufferSize);
ASSERT (Option->Description != NULL);
StrCpy (Option->Description, HiiString); StrCpy (Option->Description, HiiString);
if (StrnCmp (BootStringNumber, L"0", 1) != 0) { if (StrnCmp (BootStringNumber, L"0", 1) != 0) {
StrCat (Option->Description, L" "); StrCat (Option->Description, L" ");

View File

@ -5,7 +5,7 @@
Boot option manipulation Boot option manipulation
Copyright (c) 2004 - 2009, Intel Corporation. <BR> Copyright (c) 2004 - 2010, Intel Corporation. <BR>
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -1052,6 +1052,7 @@ BOpt_GetBootOptions (
if (HiiString != NULL) { if (HiiString != NULL) {
NewLoadContext->Description = AllocateZeroPool(StringSize + StrSize(HiiString)); NewLoadContext->Description = AllocateZeroPool(StringSize + StrSize(HiiString));
ASSERT (NewLoadContext->Description != NULL);
StrCpy (NewLoadContext->Description, HiiString); StrCpy (NewLoadContext->Description, HiiString);
if (StrnCmp ((UINT16*)LoadOptionPtr, L"0", 1) != 0) { if (StrnCmp ((UINT16*)LoadOptionPtr, L"0", 1) != 0) {
StrCat (NewLoadContext->Description, L" "); StrCat (NewLoadContext->Description, L" ");

View File

@ -1,7 +1,7 @@
/** @file /** @file
The platform boot manager reference implementation The platform boot manager reference implementation
Copyright (c) 2004 - 2008, Intel Corporation. <BR> Copyright (c) 2004 - 2010, Intel Corporation. <BR>
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -316,6 +316,7 @@ CallBootManager (
BufferSize = StrSize(BootStringNumber); BufferSize = StrSize(BootStringNumber);
BufferSize += StrSize(HiiString); BufferSize += StrSize(HiiString);
Option->Description = AllocateZeroPool(BufferSize); Option->Description = AllocateZeroPool(BufferSize);
ASSERT (Option->Description != NULL);
StrCpy (Option->Description, HiiString); StrCpy (Option->Description, HiiString);
if (StrnCmp (BootStringNumber, L"0", 1) != 0) { if (StrnCmp (BootStringNumber, L"0", 1) != 0) {
StrCat (Option->Description, L" "); StrCat (Option->Description, L" ");

View File

@ -27,7 +27,7 @@
3) A support protocol is not found, and the data is not available to be read 3) A support protocol is not found, and the data is not available to be read
without it. This results in EFI_PROTOCOL_ERROR. without it. This results in EFI_PROTOCOL_ERROR.
Copyright (c) 2006 - 2009, Intel Corporation. <BR> Copyright (c) 2006 - 2010, Intel Corporation. <BR>
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -1054,6 +1054,7 @@ FindChildNode (
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
return Status; return Status;
} }
ASSERT (CurrentChildNode != NULL);
} else { } else {
ASSERT (EFI_ERROR (ErrorStatus)); ASSERT (EFI_ERROR (ErrorStatus));
return ErrorStatus; return ErrorStatus;
@ -1204,6 +1205,8 @@ GetSection (
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
goto GetSection_Done; goto GetSection_Done;
} }
ASSERT (ChildNode != NULL);
ASSERT (ChildStreamNode != NULL);
CopySize = ChildNode->Size - sizeof (EFI_COMMON_SECTION_HEADER); CopySize = ChildNode->Size - sizeof (EFI_COMMON_SECTION_HEADER);
CopyBuffer = ChildStreamNode->StreamBuffer + ChildNode->OffsetInStream + sizeof (EFI_COMMON_SECTION_HEADER); CopyBuffer = ChildStreamNode->StreamBuffer + ChildNode->OffsetInStream + sizeof (EFI_COMMON_SECTION_HEADER);
*AuthenticationStatus = ExtractedAuthenticationStatus; *AuthenticationStatus = ExtractedAuthenticationStatus;