tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DynamicTablesPkg: Rename single char input parameter 

The Ecc tool forbids the usage of one char variable: Ecc error 8007:
"There should be no use of short (single character) variable names"

To follow this policy, rename this one letter parameter.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
This commit is contained in:
Pierre Gondois 2021-09-30 08:48:14 +01:00 committed by mergify[bot]
parent 20775950c6
commit 1ad5182500
2 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
DynamicTablesPkg/Include/Library/AcpiHelperLib.h
View File

@ -22,15 +22,16 @@
/** Convert a hex number to its ASCII code. /** Convert a hex number to its ASCII code.
@param [in] x Hex number to convert. @param [in] Hex Hex number to convert.
Must be 0 <= x < 16. Must be 0 <= x < 16.
@return The ASCII code corresponding to x. @return The ASCII code corresponding to x.
-1 if error.
**/ **/
UINT8 UINT8
EFIAPI EFIAPI
AsciiFromHex ( AsciiFromHex (
IN UINT8 x IN UINT8 Hex
); );
/** Check if a HID is a valid PNP ID. /** Check if a HID is a valid PNP ID.

15
DynamicTablesPkg/Library/Common/AcpiHelperLib/AcpiHelper.c
View File

@ -14,23 +14,24 @@
/** Convert a hex number to its ASCII code. /** Convert a hex number to its ASCII code.
@param [in] x Hex number to convert. @param [in] Hex Hex number to convert.
Must be 0 <= x < 16. Must be 0 <= x < 16.
@return The ASCII code corresponding to x. @return The ASCII code corresponding to x.
-1 if error.
**/ **/
UINT8 UINT8
EFIAPI EFIAPI
AsciiFromHex ( AsciiFromHex (
IN UINT8 x IN UINT8 Hex
) )
{ {
if (x < 10) { if (Hex < 10) {
return (UINT8)(x + '0'); return (UINT8)(Hex + '0');
} }
if (x < 16) { if (Hex < 16) {
return (UINT8)(x - 10 + 'A'); return (UINT8)(Hex - 10 + 'A');
} }
ASSERT (FALSE); ASSERT (FALSE);