Add some security check.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9934 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
xdu2 2010-02-05 06:13:18 +00:00
parent f9ec2f0f40
commit 1b2bf3cadc
4 changed files with 7 additions and 4 deletions

View File

@ -2,7 +2,7 @@
Implementation for EFI_HII_FONT_PROTOCOL.
Copyright (c) 2007 - 2009, Intel Corporation
Copyright (c) 2007 - 2010, Intel Corporation
All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@ -2392,6 +2392,7 @@ HiiGetGlyph (
if (EFI_ERROR (Status)) {
goto Exit;
}
ASSERT (StringInfoOut != NULL);
FontInfo = &StringInfoOut->FontInfo;
Foreground = StringInfoOut->ForegroundColor;
Background = StringInfoOut->BackgroundColor;
@ -2622,7 +2623,7 @@ HiiGetFontInfo (
InfoOut.BackgroundColor = SystemDefault->BackgroundColor;
}
ASSERT (FontInfo != NULL);
FontInfo->FontSize = InfoOut.FontInfo.FontSize;
FontInfo->FontStyle = InfoOut.FontInfo.FontStyle;

View File

@ -480,8 +480,7 @@ InstallVlanConfigForm (
PrivateData->MacString = MacString;
StrCpy (Str, L"VLAN Configuration (MAC:");
ASSERT (StrLen (MacString) <= (sizeof (EFI_MAC_ADDRESS) * 2));
StrCat (Str, MacString);
StrnCat (Str, MacString, sizeof (EFI_MAC_ADDRESS) * 2);
StrCat (Str, L")");
HiiSetString (
HiiHandle,

View File

@ -1505,6 +1505,7 @@ ParseOpCodes (
//
// Now we know the Storage width of nested Ordered List
//
ASSERT (CurrentStatement != NULL);
if ((CurrentStatement->Operand == EFI_IFR_ORDERED_LIST_OP) && (CurrentStatement->BufferValue == NULL)) {
Width = 1;
switch (CurrentOption->Value.Type) {

View File

@ -1138,11 +1138,13 @@ GetQuestionValue (
//
CopyMem (Dst, Storage->EditBuffer + Question->VarStoreInfo.VarOffset, StorageWidth);
} else {
Value = NULL;
Status = GetValueByName (Storage, Question->VariableName, &Value);
if (EFI_ERROR (Status)) {
return Status;
}
ASSERT (Value != NULL);
LengthStr = StrLen (Value);
Status = EFI_SUCCESS;
if (IsString) {