From 1bebc97b816ddedbaa0fbdf723c1d124d7fc84a3 Mon Sep 17 00:00:00 2001
From: "levi.yun" <yeoreum.yun@arm.com>
Date: Mon, 30 Dec 2024 11:14:17 +0000
Subject: [PATCH] ArmPkg/MmCommunication: add helper function converting smc
 return

Add helper function converting smc return value to efi status.

Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
---
 .../MmCommunicationDxe/MmCommunication.c      | 53 +++++++++++--------
 .../MmCommunicationPei/MmCommunicationPei.c   | 53 +++++++++++--------
 2 files changed, 60 insertions(+), 46 deletions(-)

diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
index e3455384fe..3c325d175a 100644
--- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
+++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
@@ -77,6 +77,35 @@ SendFfaMmCommunicate (
   return Status;
 }
 
+/**
+  Convert SmcMmRet value to EFI_STATUS.
+
+  @param[in] SmcMmRet              Mm return code
+
+  @retval EFI_SUCCESS
+  @retval Others                   Error status correspond to SmcMmRet
+
+**/
+STATIC
+EFI_STATUS
+SmcMmRetToEfiStatus (
+  IN UINTN  SmcMmRet
+  )
+{
+  switch ((UINT32)SmcMmRet) {
+    case ARM_SMC_MM_RET_SUCCESS:
+      return EFI_SUCCESS;
+    case ARM_SMC_MM_RET_INVALID_PARAMS:
+      return EFI_INVALID_PARAMETER;
+    case ARM_SMC_MM_RET_DENIED:
+      return EFI_ACCESS_DENIED;
+    case ARM_SMC_MM_RET_NO_MEMORY:
+      return EFI_OUT_OF_RESOURCES;
+    default:
+      return EFI_ACCESS_DENIED;
+  }
+}
+
 /**
   Send mm communicate request via SPM_MM.
 
@@ -91,7 +120,6 @@ SendSpmMmCommunicate (
   IN VOID
   )
 {
-  EFI_STATUS    Status;
   ARM_SMC_ARGS  CommunicateSmcArgs;
 
   ZeroMem (&CommunicateSmcArgs, sizeof (ARM_SMC_ARGS));
@@ -111,28 +139,7 @@ SendSpmMmCommunicate (
   // Call the Standalone MM environment.
   ArmCallSmc (&CommunicateSmcArgs);
 
-  switch (CommunicateSmcArgs.Arg0) {
-    case ARM_SMC_MM_RET_SUCCESS:
-      Status = EFI_SUCCESS;
-      break;
-    case ARM_SMC_MM_RET_INVALID_PARAMS:
-      Status = EFI_INVALID_PARAMETER;
-      break;
-    case ARM_SMC_MM_RET_DENIED:
-      Status = EFI_ACCESS_DENIED;
-      break;
-    case ARM_SMC_MM_RET_NO_MEMORY:
-      // Unexpected error since the CommSize was checked for zero length
-      // prior to issuing the SMC
-      Status = EFI_OUT_OF_RESOURCES;
-      ASSERT (0);
-      break;
-    default:
-      Status = EFI_ACCESS_DENIED;
-      ASSERT (0);
-  }
-
-  return Status;
+  return SmcMmRetToEfiStatus (CommunicateSmcArgs.Arg0);
 }
 
 /**
diff --git a/ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c b/ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c
index 178c9256aa..666b7a2092 100644
--- a/ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c
+++ b/ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c
@@ -280,6 +280,35 @@ SendFfaMmCommunicate (
   return Status;
 }
 
+/**
+  Convert SmcMmRet value to EFI_STATUS.
+
+  @param[in] SmcMmRet              Mm return code
+
+  @retval EFI_SUCCESS
+  @retval Others                   Error status correspond to SmcMmRet
+
+**/
+STATIC
+EFI_STATUS
+SmcMmRetToEfiStatus (
+  IN UINTN  SmcMmRet
+  )
+{
+  switch ((UINT32)SmcMmRet) {
+    case ARM_SMC_MM_RET_SUCCESS:
+      return EFI_SUCCESS;
+    case ARM_SMC_MM_RET_INVALID_PARAMS:
+      return EFI_INVALID_PARAMETER;
+    case ARM_SMC_MM_RET_DENIED:
+      return EFI_ACCESS_DENIED;
+    case ARM_SMC_MM_RET_NO_MEMORY:
+      return EFI_OUT_OF_RESOURCES;
+    default:
+      return EFI_ACCESS_DENIED;
+  }
+}
+
 /**
   Send mm communicate request via SPM_MM.
 
@@ -294,7 +323,6 @@ SendSpmMmCommunicate (
   VOID
   )
 {
-  EFI_STATUS    Status;
   ARM_SMC_ARGS  CommunicateSmcArgs;
 
   ZeroMem (&CommunicateSmcArgs, sizeof (ARM_SMC_ARGS));
@@ -314,28 +342,7 @@ SendSpmMmCommunicate (
   // Call the Standalone MM environment.
   ArmCallSmc (&CommunicateSmcArgs);
 
-  switch (CommunicateSmcArgs.Arg0) {
-    case ARM_SMC_MM_RET_SUCCESS:
-      Status = EFI_SUCCESS;
-      break;
-    case ARM_SMC_MM_RET_INVALID_PARAMS:
-      Status = EFI_INVALID_PARAMETER;
-      break;
-    case ARM_SMC_MM_RET_DENIED:
-      Status = EFI_ACCESS_DENIED;
-      break;
-    case ARM_SMC_MM_RET_NO_MEMORY:
-      // Unexpected error since the CommSize was checked for zero length
-      // prior to issuing the SMC
-      Status = EFI_OUT_OF_RESOURCES;
-      ASSERT (0);
-      break;
-    default:
-      Status = EFI_ACCESS_DENIED;
-      ASSERT (0);
-  }
-
-  return Status;
+  return SmcMmRetToEfiStatus (CommunicateSmcArgs.Arg0);
 }
 
 /**