tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NetworkPkg/HttpDxe: Fix build warning error if CHAR8 is unsigned. 

This patch is to fix the compiler warning error: C4245. The issue will happen
if the below build option is enabled:
  *_*_*_CC_FLAGS = -J.

That's because the value of ('A' - 'a') is a negative value, which will
be converted to an unsigned type if CHAR8 is treated as unsigned:
  Src -= ('A' - 'a');

The above issue is also recorded at:
https://bugzilla.tianocore.org/show_bug.cgi?id=815.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
This commit is contained in:
Jiaxin Wu 2018-01-02 11:29:03 +08:00
parent 36c19ee6c7
commit 1e4725e569
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
NetworkPkg/HttpDxe/HttpsSupport.c
View File

@ -67,11 +67,11 @@ AsciiStrCaseStr (
Dst = *SearchStringTmp; Dst = *SearchStringTmp;
if ((Src >= 'A') && (Src <= 'Z')) { if ((Src >= 'A') && (Src <= 'Z')) {
Src -= ('A' - 'a'); Src += ('a' - 'A');
} }
if ((Dst >= 'A') && (Dst <= 'Z')) { if ((Dst >= 'A') && (Dst <= 'Z')) {
Dst -= ('A' - 'a'); Dst += ('a' - 'A');
} }
if (Src != Dst) { if (Src != Dst) {