tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/AtaAtapiPassThru: relax PHY detect timeout 

The SATA spec mandates that link detection by the PHY completes within
10 ms after receiving a reset signal. However, there is no obligation
to uphold this requirement at the driver end as strictly as we do, and
as it turns out, some combinations of host and device (e.g., Samsung
850 EVO connected to a LeMaker Cello) are only borderline compliant,
which means the device is not detected reliably.

So let's allow for a bit of margin, and increase the PHY detect timeout
value to 15 ms.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Star Zeng <star.zeng@intel.com>
This commit is contained in:
Ard Biesheuvel 2017-06-23 14:50:53 +00:00
parent 157fb7bf29
commit 1fb805b1eb
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
View File

@ -2376,8 +2376,7 @@ AhciModeInitialization (
AhciOrReg (PciIo, Offset, EFI_AHCI_PORT_CMD_FRE); AhciOrReg (PciIo, Offset, EFI_AHCI_PORT_CMD_FRE);
// //
// Wait no longer than 10 ms to wait the Phy to detect the presence of a device. // Wait for the Phy to detect the presence of a device.
// It's the requirment from SATA1.0a spec section 5.2.
// //
PhyDetectDelay = EFI_AHCI_BUS_PHY_DETECT_TIMEOUT; PhyDetectDelay = EFI_AHCI_BUS_PHY_DETECT_TIMEOUT;
Offset = EFI_AHCI_PORT_START + Port * EFI_AHCI_PORT_REG_WIDTH + EFI_AHCI_PORT_SSTS; Offset = EFI_AHCI_PORT_START + Port * EFI_AHCI_PORT_REG_WIDTH + EFI_AHCI_PORT_SSTS;

3
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h
View File

@ -41,8 +41,9 @@ typedef union {
// //
// Refer SATA1.0a spec section 5.2, the Phy detection time should be less than 10ms. // Refer SATA1.0a spec section 5.2, the Phy detection time should be less than 10ms.
// Add a bit of margin for robustness.
// //
#define EFI_AHCI_BUS_PHY_DETECT_TIMEOUT 10 #define EFI_AHCI_BUS_PHY_DETECT_TIMEOUT 15
// //
// Refer SATA1.0a spec, the FIS enable time should be less than 500ms. // Refer SATA1.0a spec, the FIS enable time should be less than 500ms.
// //