From 22b080c78c7a017c1ca96535d33d53ea58e3859a Mon Sep 17 00:00:00 2001 From: Ard Biesheuvel Date: Wed, 10 Aug 2016 14:39:26 +0200 Subject: [PATCH] ArmPkg/SemihostLib: switch to ASM_FUNC() asm macro Annotate functions with ASM_FUNC() so that they are emitted into separate sections. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- ArmPkg/Library/SemihostLib/AArch64/GccSemihost.S | 7 ++----- ArmPkg/Library/SemihostLib/Arm/GccSemihost.S | 8 ++------ 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/ArmPkg/Library/SemihostLib/AArch64/GccSemihost.S b/ArmPkg/Library/SemihostLib/AArch64/GccSemihost.S index 42211cf4ff..43a780c9ed 100644 --- a/ArmPkg/Library/SemihostLib/AArch64/GccSemihost.S +++ b/ArmPkg/Library/SemihostLib/AArch64/GccSemihost.S @@ -13,11 +13,8 @@ # #------------------------------------------------------------------------------ -.text -.align 2 +#include -.globl ASM_PFX(GccSemihostCall) - -ASM_PFX(GccSemihostCall): +ASM_FUNC(GccSemihostCall) hlt #0xf000 ret diff --git a/ArmPkg/Library/SemihostLib/Arm/GccSemihost.S b/ArmPkg/Library/SemihostLib/Arm/GccSemihost.S index c9d13183f6..770e512cfb 100644 --- a/ArmPkg/Library/SemihostLib/Arm/GccSemihost.S +++ b/ArmPkg/Library/SemihostLib/Arm/GccSemihost.S @@ -12,11 +12,7 @@ # #------------------------------------------------------------------------------ -.text -.align 2 - -.globl ASM_PFX(GccSemihostCall) -INTERWORK_FUNC(GccSemihostCall) +#include /* Semihosting operation request mechanism @@ -32,7 +28,7 @@ INTERWORK_FUNC(GccSemihostCall) the svc lr register. That happens to be the one we are using, so we must save it or we will not be able to return. */ -ASM_PFX(GccSemihostCall): +ASM_FUNC(GccSemihostCall) stmfd sp!, {lr} svc #0x123456 ldmfd sp!, {lr}