From 2394f31c55b7a1bd0c1f944a4716885e07b6df03 Mon Sep 17 00:00:00 2001 From: shenglei Date: Wed, 8 Aug 2018 16:17:14 +0800 Subject: [PATCH] MdeModulePkg SdBlockIoPei: Remove a redundant function The function SdPeimUnlinkMemBlock that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 v2: Remove the comment that mentioned 'SdPeimUnlinkMemBlock' within function SdPeimFreeMemPool(). Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Hao Wu Reviewed-by: Star Zeng --- MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 26 ---------------------- 1 file changed, 26 deletions(-) diff --git a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c index 24ad3dc6c2..03b7963716 100644 --- a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c +++ b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c @@ -219,31 +219,7 @@ SdPeimIsMemBlockEmpty ( return TRUE; } -/** - Unlink the memory block from the pool's list. - @param Head The block list head of the memory's pool. - @param BlockToUnlink The memory block to unlink. - -**/ -VOID -SdPeimUnlinkMemBlock ( - IN SD_PEIM_MEM_BLOCK *Head, - IN SD_PEIM_MEM_BLOCK *BlockToUnlink - ) -{ - SD_PEIM_MEM_BLOCK *Block; - - ASSERT ((Head != NULL) && (BlockToUnlink != NULL)); - - for (Block = Head; Block != NULL; Block = Block->Next) { - if (Block->Next == BlockToUnlink) { - Block->Next = BlockToUnlink->Next; - BlockToUnlink->Next = NULL; - break; - } - } -} /** Initialize the memory management pool for the host controller. @@ -305,8 +281,6 @@ SdPeimFreeMemPool ( // // Unlink all the memory blocks from the pool, then free them. - // SdPeimUnlinkMemBlock can't be used to unlink and free the - // first block. // for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) { SdPeimFreeMemBlock (Pool, Block);