tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-28 16:14:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

A complement fix for revision 11664 to update GCC assembly files : clear the direction flag in interrupt/exception handlers' assembly entry code before calling C functions to follow the UEFI calling convention.

Browse Source 
Signed-off-by: rsun3
Reviewed-by:  jyao1


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11670 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
rsun3 2011-05-17 08:35:20 +00:00
parent 8b6d0c057f
commit 24f7e42cb7
4 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
MdeModulePkg/Universal/DebugSupportDxe/Ia32/AsmFuncs.S
View File

@ -1,7 +1,7 @@
#/**@file #/**@file
# Low leve IA32 specific debug support functions. # Low leve IA32 specific debug support functions.
# #
# Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR> # Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials # This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License # are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at # which accompanies this distribution. The full text of the license may be found at
@ -276,6 +276,9 @@ ASM_PFX(CommonIdtEntry):
# They MUST be. If they are not, a GP fault will occur. # They MUST be. If they are not, a GP fault will occur.
fxsave (%edi) fxsave (%edi)
## UEFI calling convention for IA32 requires that Direction flag in EFLAGs is clear
cld
## UINT32 ExceptionData; ## UINT32 ExceptionData;
mov 0x0,%eax mov 0x0,%eax
push %eax push %eax

5
MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.S
View File

@ -1,7 +1,7 @@
///**@file ///**@file
// Low leve x64 specific debug support functions. // Low leve x64 specific debug support functions.
// //
// Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR> // Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
// Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR> // Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>
// This program and the accompanying materials // This program and the accompanying materials
// are licensed and made available under the terms and conditions of the BSD License // are licensed and made available under the terms and conditions of the BSD License
@ -357,6 +357,9 @@ ExtraPushDone:
# FXSTOR_RDI # FXSTOR_RDI
fxsave (%rdi) fxsave (%rdi)
// UEFI calling convention for x64 requires that Direction flag in EFLAGs is clear
cld
// UINT64 ExceptionData; // UINT64 ExceptionData;
movq ASM_PFX(ExceptData)(%rip), %rax movq ASM_PFX(ExceptData)(%rip), %rax
pushq %rax pushq %rax

5
UefiCpuPkg/CpuDxe/Ia32/CpuAsm.S
View File

@ -1,6 +1,6 @@
#------------------------------------------------------------------------------ #------------------------------------------------------------------------------
#* #*
#* Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR> #* Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
#* This program and the accompanying materials #* This program and the accompanying materials
#* are licensed and made available under the terms and conditions of the BSD License #* are licensed and made available under the terms and conditions of the BSD License
#* which accompanies this distribution. The full text of the license may be found at #* which accompanies this distribution. The full text of the license may be found at
@ -274,6 +274,9 @@ ErrorCodeAndVectorOnStack:
movl %esp, %edi movl %esp, %edi
.byte 0x0f, 0x0ae, 0x07 #fxsave [edi] .byte 0x0f, 0x0ae, 0x07 #fxsave [edi]
#; UEFI calling convention for IA32 requires that Direction flag in EFLAGs is clear
cld
#; UINT32 ExceptionData; #; UINT32 ExceptionData;
pushl 8(%ebp) pushl 8(%ebp)

5
UefiCpuPkg/CpuDxe/X64/CpuAsm.S
View File

@ -2,7 +2,7 @@
#------------------------------------------------------------------------------ #------------------------------------------------------------------------------
#* #*
#* Copyright (c) 2008 - 2010, Intel Corporation. All rights reserved.<BR> #* Copyright (c) 2008 - 2011, Intel Corporation. All rights reserved.<BR>
#* This program and the accompanying materials #* This program and the accompanying materials
#* are licensed and made available under the terms and conditions of the BSD License #* are licensed and made available under the terms and conditions of the BSD License
#* which accompanies this distribution. The full text of the license may be found at #* which accompanies this distribution. The full text of the license may be found at
@ -234,6 +234,9 @@ CommonInterruptEntry_al_0000:
movq %rsp, %rdi movq %rsp, %rdi
.byte 0x0f, 0x0ae, 0x07 #fxsave [rdi] .byte 0x0f, 0x0ae, 0x07 #fxsave [rdi]
#; UEFI calling convention for x64 requires that Direction flag in EFLAGs is clear
cld
#; UINT32 ExceptionData; #; UINT32 ExceptionData;
pushq 16(%rbp) pushq 16(%rbp)