tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix Klocwork issues 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7926 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
hfang 2009-03-23 09:12:51 +00:00
parent 3fb46d0b04
commit 261136bc32
7 changed files with 31 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c
View File

@ -353,11 +353,13 @@ ErrorExit:
// Since there will be no timer handler for keyboard input any more,
// exhaust input data just in case there is still keyboard data left
//
Status1 = EFI_SUCCESS;
while (!EFI_ERROR (Status1)) {
Status1 = KeyboardRead (ConsoleIn, &Data);;
if (ConsoleIn != NULL) {
Status1 = EFI_SUCCESS;
while (!EFI_ERROR (Status1)) {
Status1 = KeyboardRead (ConsoleIn, &Data);;
}
}
if (ConsoleIn != NULL) {
gBS->FreePool (ConsoleIn);
}

6
IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ata.c
View File

@ -63,6 +63,9 @@ ATAIdentify (
// the ATA Identify command
//
AtaIdentifyPointer = (EFI_IDENTIFY_DATA *) AllocateZeroPool (sizeof (EFI_IDENTIFY_DATA));
if (AtaIdentifyPointer == NULL) {
return EFI_OUT_OF_RESOURCES;
}
//
// use ATA PIO Data In protocol to send ATA Identify command
@ -1824,6 +1827,9 @@ AtaSMARTSupport (
// Detect if this feature is enabled
//
TmpAtaIdentifyPointer = (EFI_IDENTIFY_DATA *) AllocateZeroPool (sizeof (EFI_IDENTIFY_DATA));
if (TmpAtaIdentifyPointer == NULL) {
return;
}
DeviceSelect = (UINT8) ((IdeDev->Device) << 4);
Status = AtaPioDataIn (

2
IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c
View File

@ -1791,7 +1791,7 @@ AtapiBlkIoReadBlocks (
//
if (LBA == 0 && (IdeBlkIoDevice->Cache == NULL)) {
IdeBlkIoDevice->Cache = AllocatePool (BlockSize);
if (IdeBlkIoDevice != NULL) {
if (IdeBlkIoDevice->Cache!= NULL) {
CopyMem ((UINT8 *) IdeBlkIoDevice->Cache, (UINT8 *) Buffer, BlockSize);
}
}

4
IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeSupport.c
View File

@ -125,7 +125,9 @@ InternalReportStatusCodeEx (
//
// Fill in the extended data buffer
//
CopyMem (StatusCodeData + 1, ExtendedData, ExtendedDataSize);
if (ExtendedData != NULL) {
CopyMem (StatusCodeData + 1, ExtendedData, ExtendedDataSize);
}
//
// Report the status code

9
IntelFrameworkModulePkg/Library/PciIncompatibleDeviceSupportLib/PciIncompatibleDeviceSupportLib.c
View File

@ -137,6 +137,9 @@ PciResourceUpdateCheck (
AcpiPtr = AllocateZeroPool (
sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) * Index + sizeof (EFI_ACPI_END_TAG_DESCRIPTOR)
);
if (AcpiPtr == NULL) {
return EFI_OUT_OF_RESOURCES;
}
OldAcpiPtr = AcpiPtr;
@ -255,6 +258,9 @@ PciRegisterUpdateCheck (
Dsc = (EFI_PCI_REGISTER_VALUE_DATA *) (ListPtr + 2);
RegisterPtr = AllocateZeroPool (sizeof (EFI_PCI_REGISTER_VALUE_DATA));
if (RegisterPtr == NULL) {
return EFI_SUCCESS;
}
RegisterPtr->AndValue = Dsc->AndValue;
RegisterPtr->OrValue = Dsc->OrValue;
@ -356,6 +362,9 @@ PciRegisterAccessCheck (
if((Dsc->StartOffset <= Offset) && (Dsc->EndOffset > Offset)) {
RegisterPtr = AllocateZeroPool (sizeof (EFI_PCI_REGISTER_ACCESS_DATA));
if (RegisterPtr == NULL) {
return EFI_OUT_OF_RESOURCES;
}
RegisterPtr->StartOffset = Dsc->StartOffset;
RegisterPtr->EndOffset = Dsc->EndOffset;

4
IntelFrameworkModulePkg/Library/PeiReportStatusCodeLib/ReportStatusCodeLib.c
View File

@ -471,7 +471,9 @@ ReportStatusCodeEx (
ExtendedDataGuid = &gEfiStatusCodeSpecificDataGuid;
}
CopyGuid (&StatusCodeData->Type, ExtendedDataGuid);
CopyMem (StatusCodeData + 1, ExtendedData, ExtendedDataSize);
if (ExtendedData != NULL) {
CopyMem (StatusCodeData + 1, ExtendedData, ExtendedDataSize);
}
if (CallerId == NULL) {
CallerId = &gEfiCallerIdGuid;
}

4
IntelFrameworkModulePkg/Library/SmmRuntimeDxeReportStatusCodeLibFramework/SmmRuntimeDxeSupport.c
View File

@ -292,7 +292,9 @@ InternalReportStatusCodeEx (
//
// Fill in the extended data buffer
//
CopyMem (mStatusCodeData + 1, ExtendedData, ExtendedDataSize);
if (ExtendedData != NULL) {
CopyMem (mStatusCodeData + 1, ExtendedData, ExtendedDataSize);
}
//
// Report the status code