Fix the issues,

1. NULL Pointer Errors in Variable.c
2. consoleoption Null Ptr Error
3. bootmaint Null Ptr Error
4. EFIAPI missing Crc32SectionExtraction.c  


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@2252 6f19259b-4bc3-4df7-8a09-765794883524

EdkModulePkg/Universal/FirmwareVolume/GuidedSectionExtraction/Crc32SectionExtract/Dxe/Crc32SectionExtract.c

@@ -28,12 +28,14 @@ Abstract:
 #include <Crc32SectionExtract.h>
 
 EFI_STATUS
+EFIAPI
 InitializeCrc32GuidedSectionExtractionProtocol (
   IN EFI_HANDLE                   ImageHandle,
   IN EFI_SYSTEM_TABLE             *SystemTable
   );
 
 EFI_STATUS
+EFIAPI
 InitializeCrc32GuidedSectionExtractionProtocol (
   IN EFI_HANDLE                   ImageHandle,
   IN EFI_SYSTEM_TABLE             *SystemTable
@@ -98,6 +100,7 @@ Returns:
 
 STATIC
 UINT32
+EFIAPI
 GetSectionLength (
   IN EFI_COMMON_SECTION_HEADER  *CommonHeader
   )
@@ -126,6 +129,7 @@ GetSectionLength (
 
 STATIC
 EFI_STATUS
+EFIAPI
 Crc32ExtractSection (
   IN  EFI_GUIDED_SECTION_EXTRACTION_PROTOCOL  *This,
   IN  VOID                                    *InputSection,

EdkModulePkg/Universal/FirmwareVolume/GuidedSectionExtraction/Crc32SectionExtract/Dxe/Crc32SectionExtract.h

@@ -34,6 +34,7 @@ typedef struct {
 //
 STATIC
 EFI_STATUS
+EFIAPI
 Crc32ExtractSection (
   IN  EFI_GUIDED_SECTION_EXTRACTION_PROTOCOL  *This,
   IN  VOID                                    *InputSection,

EdkNt32Pkg/Dxe/PlatformBds/Generic/BootMaint/BootMaint.c

@@ -449,6 +449,7 @@ Returns:
       Index2                  = (UINT16) (KeyValue - HANDLE_OPTION_OFFSET);
 
       NewMenuEntry            = BOpt_GetMenuEntry (&DriverMenu, Index2);
+      ASSERT (NewMenuEntry != NULL);
       Private->HandleContext  = (BM_HANDLE_CONTEXT *) NewMenuEntry->VariableContext;
 
       CleanUpPage (FORM_DRV_ADD_HANDLE_DESC_ID, Private);
@@ -556,6 +557,8 @@ Returns:
   case FORM_CON_COM_ID:
     NewMenuEntry                      = BOpt_GetMenuEntry (&TerminalMenu, Private->CurrentTerminal);
 
+    ASSERT (NewMenuEntry != NULL);
+
     NewTerminalContext                = (BM_TERMINAL_CONTEXT *) NewMenuEntry->VariableContext;
 
     NewTerminalContext->BaudRateIndex = CurrentFakeNVMap->COMBaudRate;

EdkNt32Pkg/Dxe/PlatformBds/Generic/BootMaint/ConsoleOption.c

@@ -175,6 +175,7 @@ ChangeVariableDevicePath (
                       &TerminalMenu,
                       Com
                       );
+      ASSERT (NewMenuEntry != NULL);
       NewTerminalContext  = (BM_TERMINAL_CONTEXT *) NewMenuEntry->VariableContext;
       Uart                = (UART_DEVICE_PATH *) Node;
       CopyMem (

EdkNt32Pkg/Dxe/PlatformBds/Generic/BootMaint/Variable.c

@@ -450,6 +450,7 @@ Var_UpdateConsoleOption (
                             NewTerminalContext->DevicePath,
                             (EFI_DEVICE_PATH_PROTOCOL *) &Vendor
                             );
+      ASSERT (TerminalDevicePath != NULL);
       ChangeTerminalDevicePath (TerminalDevicePath, TRUE);
       Temp = DevicePathToStr (TerminalDevicePath);
       ConDevicePath = AppendDevicePathInstance (

EdkUnixPkg/Dxe/PlatformBds/Generic/BootMaint/ConsoleOption.c

@@ -175,6 +175,7 @@ ChangeVariableDevicePath (
                       &TerminalMenu,
                       Com
                       );
+      ASSERT (NewMenuEntry != NULL);
       NewTerminalContext  = (BM_TERMINAL_CONTEXT *) NewMenuEntry->VariableContext;
       Uart                = (UART_DEVICE_PATH *) Node;
       CopyMem (

EdkUnixPkg/Dxe/PlatformBds/Generic/BootMaint/Variable.c

@@ -450,6 +450,7 @@ Var_UpdateConsoleOption (
                             NewTerminalContext->DevicePath,
                             (EFI_DEVICE_PATH_PROTOCOL *) &Vendor
                             );
+      ASSERT (TerminalDevicePath != NULL);
       ChangeTerminalDevicePath (TerminalDevicePath, TRUE);
       Temp = DevicePathToStr (TerminalDevicePath);
       ConDevicePath = AppendDevicePathInstance (