tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

1. Add comments in INF file to describe limitation. 

2. Return EFI_UNSUPPORTED where reasonable.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9850 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
xli24 2010-01-28 08:29:35 +00:00
parent 819aa7bc72
commit 2c4297cf56
2 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
MdeModulePkg/Universal/LegacyRegion2Dxe/LegacyRegion2.c
View File

@ -7,7 +7,7 @@
be used as a template driver for implementing the Legacy Region 2 Protocol on be used as a template driver for implementing the Legacy Region 2 Protocol on
a platform that does support HW locking of the legacy memory regions. a platform that does support HW locking of the legacy memory regions.
Copyright (c) 2009, Intel Corporation Copyright (c) 2009 - 2010, Intel Corporation
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -149,9 +149,7 @@ LegacyRegion2BootLock (
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
} }
ASSERT (Granularity != NULL); return EFI_UNSUPPORTED;
*Granularity = 0;
return EFI_SUCCESS;
} }
/** /**
@ -199,7 +197,7 @@ LegacyRegion2Unlock (
region. Each attribute may have a different granularity and the granularity may not be the same region. Each attribute may have a different granularity and the granularity may not be the same
for all memory ranges in the legacy region. for all memory ranges in the legacy region.
@param This[in] Indicates the EFI_LEGACY_REGION_PROTOCOL instance. @param This[in] Indicates the EFI_LEGACY_REGION2_PROTOCOL instance.
@param DescriptorCount[out] The number of region descriptor entries returned in the Descriptor @param DescriptorCount[out] The number of region descriptor entries returned in the Descriptor
buffer. buffer.
@param Descriptor[out] A pointer to a pointer used to return a buffer where the legacy @param Descriptor[out] A pointer to a pointer used to return a buffer where the legacy
@ -207,8 +205,8 @@ LegacyRegion2Unlock (
DescriptorCount number of region descriptors. This function will DescriptorCount number of region descriptors. This function will
provide the memory for the buffer. provide the memory for the buffer.
@retval EFI_SUCCESS The region's attributes were successfully modified. @retval EFI_SUCCESS The information structure was returned.
@retval EFI_INVALID_PARAMETER If Start or Length describe an address not in the Legacy Region. @retval EFI_UNSUPPORTED This function is not supported.
**/ **/
EFI_STATUS EFI_STATUS
@ -219,13 +217,7 @@ LegacyRegionGetInfo (
OUT EFI_LEGACY_REGION_DESCRIPTOR **Descriptor OUT EFI_LEGACY_REGION_DESCRIPTOR **Descriptor
) )
{ {
ASSERT (DescriptorCount != NULL); return EFI_UNSUPPORTED;
ASSERT (Descriptor != NULL);
*DescriptorCount = 0;
*Descriptor = NULL;
return EFI_SUCCESS;
} }
/** /**

6
MdeModulePkg/Universal/LegacyRegion2Dxe/LegacyRegion2Dxe.inf
View File

@ -7,7 +7,11 @@
# be used as a template driver for implementing the Legacy Region 2 Protocol on # be used as a template driver for implementing the Legacy Region 2 Protocol on
# a platform that does support HW locking of the legacy memory regions. # a platform that does support HW locking of the legacy memory regions.
# #
# Copyright (c) 2009, Intel Corporation # Note: This module does not fully comply with PI Specification of Legacy Region 2
# Protocol. For Lock/UnLock/Decode, EFI_SUCCESS is returned although the region's
# attributes were not actually modified.
#
# Copyright (c) 2009 - 2010, Intel Corporation
# All rights reserved. This program and the accompanying materials # All rights reserved. This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License # are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at # which accompanies this distribution. The full text of the license may be found at