From 30334126c78ce5da28e7296e1500d780344efb34 Mon Sep 17 00:00:00 2001 From: Joey Vagedes Date: Mon, 22 Jan 2024 14:41:15 -0800 Subject: [PATCH] .pytool/Plugin: UncrustifyCheck: use stat instead of os.stat The UncrustifyCheck plugin passes os.stat.S_IWRITE to os.chmod, when attempting to change file permissions. os.stat.S_IWRITE does not exist as os.stat is a function. The correct value is stat.S_IWRITE. Signed-off-by: Joey Vagedes Cc: Liming Gao Cc: Michael D Kinney Cc: Sean Brogan Reviewed-by: Michael D Kinney --- .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py index 9aeef5a5a3..73dc03c0dc 100644 --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py @@ -12,6 +12,7 @@ import logging import os import pathlib import shutil +import stat import timeit from edk2toolext.environment import version_aggregator from edk2toolext.environment.plugin_manager import PluginManager @@ -628,7 +629,7 @@ class UncrustifyCheck(ICiBuildPlugin): """ Private function to attempt to change permissions on file/folder being deleted. """ - os.chmod(path, os.stat.S_IWRITE) + os.chmod(path, stat.S_IWRITE) func(path) for _ in range(3): # retry up to 3 times