tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-29 16:44:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Code scrub for BdsDxe module.

Browse Source 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5547 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
klu2 2008-07-22 06:46:58 +00:00
parent a4ac253108
commit 30394aa175
27 changed files with 187 additions and 381 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
MdeModulePkg/Universal/BdsDxe/BdsEntry.c
View File

@ -18,14 +18,14 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#include "Hotkey.h" #include "Hotkey.h"
#include "HwErrRecSupport.h" #include "HwErrRecSupport.h"
// ///
// BDS arch protocol instance initial value. /// BDS arch protocol instance initial value.
// ///
// Note: Current BDS not directly get the BootMode, DefaultBoot, /// Note: Current BDS not directly get the BootMode, DefaultBoot,
// TimeoutDefault, MemoryTestLevel value from the BDS arch protocol. /// TimeoutDefault, MemoryTestLevel value from the BDS arch protocol.
// Please refer to the library useage of BdsLibGetBootMode, BdsLibGetTimeout /// Please refer to the library useage of BdsLibGetBootMode, BdsLibGetTimeout
// and PlatformBdsDiagnostics in BdsPlatform.c /// and PlatformBdsDiagnostics in BdsPlatform.c
// ///
EFI_BDS_ARCH_PROTOCOL_INSTANCE gBdsInstanceTemplate = { EFI_BDS_ARCH_PROTOCOL_INSTANCE gBdsInstanceTemplate = {
EFI_BDS_ARCH_PROTOCOL_INSTANCE_SIGNATURE, EFI_BDS_ARCH_PROTOCOL_INSTANCE_SIGNATURE,
NULL, NULL,

71
MdeModulePkg/Universal/BdsDxe/BootMaint/BBSsupport.c
View File

@ -28,8 +28,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
@param Size The number of characters to translate. @param Size The number of characters to translate.
@param UStr Pointer to output Unicode string buffer. @param UStr Pointer to output Unicode string buffer.
@return None
**/ **/
VOID VOID
AsciiToUnicodeSize ( AsciiToUnicodeSize (
@ -52,38 +50,6 @@ AsciiToUnicodeSize (
UStr[Idx] = 0; UStr[Idx] = 0;
} }
/**
change a Unicode string t ASCII string
@param UStr Unicode string
Lenght - most possible length of AStr
@param Length The length of UStr.
@param AStr ASCII string to pass out
@return Actual length
**/
UINTN
UnicodeToAscii (
IN CHAR16 *UStr,
IN UINTN Length,
OUT CHAR8 *AStr
)
{
UINTN Index;
//
// just buffer copy, not character copy
//
for (Index = 0; Index < Length; Index++) {
*AStr++ = (CHAR8) *UStr++;
}
return Index;
}
/** /**
Build Legacy Device Name String according. Build Legacy Device Name String according.
@ -92,8 +58,6 @@ UnicodeToAscii (
@param BufSize The buffer size. @param BufSize The buffer size.
@param BootString The output string. @param BootString The output string.
@return VOID No output.
**/ **/
VOID VOID
BdsBuildLegacyDevNameString ( BdsBuildLegacyDevNameString (
@ -248,7 +212,7 @@ BdsCreateLegacyBootOption (
BOOLEAN IndexNotFound; BOOLEAN IndexNotFound;
BBS_BBS_DEVICE_PATH *NewBbsDevPathNode; BBS_BBS_DEVICE_PATH *NewBbsDevPathNode;
if (NULL == (*BootOrderList)) { if ((*BootOrderList) == NULL) {
CurrentBootOptionNo = 0; CurrentBootOptionNo = 0;
} else { } else {
for (ArrayIndex = 0; ArrayIndex < (UINTN) (*BootOrderListSize / sizeof (UINT16)); ArrayIndex++) { for (ArrayIndex = 0; ArrayIndex < (UINTN) (*BootOrderListSize / sizeof (UINT16)); ArrayIndex++) {
@ -282,7 +246,8 @@ BdsCreateLegacyBootOption (
// //
// Create new BBS device path node with description string // Create new BBS device path node with description string
// //
UnicodeToAscii (BootDesc, StrSize (BootDesc), HelpString); UnicodeStrToAsciiStr ((CONST CHAR16*)&BootDesc, (CHAR8*)&HelpString);
StringLen = AsciiStrLen (HelpString); StringLen = AsciiStrLen (HelpString);
NewBbsDevPathNode = AllocateZeroPool (sizeof (BBS_BBS_DEVICE_PATH) + StringLen); NewBbsDevPathNode = AllocateZeroPool (sizeof (BBS_BBS_DEVICE_PATH) + StringLen);
if (NewBbsDevPathNode == NULL) { if (NewBbsDevPathNode == NULL) {
@ -431,8 +396,6 @@ BdsIsLegacyBootOption (
/** /**
Delete all the invalid legacy boot options. Delete all the invalid legacy boot options.
@retval EFI_SUCCESS All invalide legacy boot options are deleted. @retval EFI_SUCCESS All invalide legacy boot options are deleted.
@retval EFI_OUT_OF_RESOURCES Fail to allocate necessary memory. @retval EFI_OUT_OF_RESOURCES Fail to allocate necessary memory.
@retval EFI_NOT_FOUND Fail to retrive variable of boot order. @retval EFI_NOT_FOUND Fail to retrive variable of boot order.
@ -503,6 +466,9 @@ BdsDeleteAllInvalidLegacyBootOptions (
return EFI_OUT_OF_RESOURCES; return EFI_OUT_OF_RESOURCES;
} }
//
// Skip Non-Legacy boot options
//
if (!BdsIsLegacyBootOption (BootOptionVar, &BbsEntry, &BbsIndex)) { if (!BdsIsLegacyBootOption (BootOptionVar, &BbsEntry, &BbsIndex)) {
SafeFreePool (BootOptionVar); SafeFreePool (BootOptionVar);
Index++; Index++;
@ -544,6 +510,9 @@ BdsDeleteAllInvalidLegacyBootOptions (
); );
} }
//
// Adjust the number of boot options.
//
if (BootOrderSize != 0) { if (BootOrderSize != 0) {
Status = gRT->SetVariable ( Status = gRT->SetVariable (
L"BootOrder", L"BootOrder",
@ -600,6 +569,9 @@ BdsFindLegacyBootOptionByDevType (
return Found; return Found;
} }
//
// Loop all boot option from variable
//
for (BootOrderIndex = 0; BootOrderIndex < BootOptionNum; BootOrderIndex++) { for (BootOrderIndex = 0; BootOrderIndex < BootOptionNum; BootOrderIndex++) {
Index = (UINTN) BootOrder[BootOrderIndex]; Index = (UINTN) BootOrder[BootOrderIndex];
UnicodeSPrint (BootOption, sizeof (BootOption), L"Boot%04x", Index); UnicodeSPrint (BootOption, sizeof (BootOption), L"Boot%04x", Index);
@ -612,6 +584,9 @@ BdsFindLegacyBootOptionByDevType (
continue; continue;
} }
//
// Skip Non-legacy boot option
//
if (!BdsIsLegacyBootOption (BootOptionVar, &BbsEntry, BbsIndex)) { if (!BdsIsLegacyBootOption (BootOptionVar, &BbsEntry, BbsIndex)) {
SafeFreePool (BootOptionVar); SafeFreePool (BootOptionVar);
continue; continue;
@ -659,6 +634,9 @@ BdsCreateOneLegacyBootOption (
DevPath = NULL; DevPath = NULL;
//
// Create device path node.
//
BbsDevPathNode.Header.Type = BBS_DEVICE_PATH; BbsDevPathNode.Header.Type = BBS_DEVICE_PATH;
BbsDevPathNode.Header.SubType = BBS_BBS_DP; BbsDevPathNode.Header.SubType = BBS_BBS_DP;
SetDevicePathNodeLength (&BbsDevPathNode.Header, sizeof (BBS_BBS_DEVICE_PATH)); SetDevicePathNodeLength (&BbsDevPathNode.Header, sizeof (BBS_BBS_DEVICE_PATH));
@ -691,8 +669,6 @@ BdsCreateOneLegacyBootOption (
Add the legacy boot options from BBS table if they do not exist. Add the legacy boot options from BBS table if they do not exist.
@retval EFI_SUCCESS The boot options are added successfully @retval EFI_SUCCESS The boot options are added successfully
or they are already in boot options. or they are already in boot options.
@ -876,6 +852,9 @@ BdsCreateDevOrder (
Ptr = NULL; Ptr = NULL;
Status = EFI_SUCCESS; Status = EFI_SUCCESS;
//
// Count all boot devices
//
for (Index = 0; Index < BbsCount; Index++) { for (Index = 0; Index < BbsCount; Index++) {
if (BbsTable[Index].BootPriority == BBS_IGNORE_ENTRY) { if (BbsTable[Index].BootPriority == BBS_IGNORE_ENTRY) {
continue; continue;
@ -913,6 +892,9 @@ BdsCreateDevOrder (
TotalSize += (HeaderSize + sizeof (UINT16) * NETCount); TotalSize += (HeaderSize + sizeof (UINT16) * NETCount);
TotalSize += (HeaderSize + sizeof (UINT16) * BEVCount); TotalSize += (HeaderSize + sizeof (UINT16) * BEVCount);
//
// Create buffer to hold all boot device order
//
DevOrder = AllocateZeroPool (TotalSize); DevOrder = AllocateZeroPool (TotalSize);
if (NULL == DevOrder) { if (NULL == DevOrder) {
return EFI_OUT_OF_RESOURCES; return EFI_OUT_OF_RESOURCES;
@ -960,6 +942,9 @@ BdsCreateDevOrder (
Ptr = (UINT8 *) BdsFillDevOrderBuf (BbsTable, BBS_BEV_DEVICE, BbsCount, (UINT16 *) Ptr); Ptr = (UINT8 *) BdsFillDevOrderBuf (BbsTable, BBS_BEV_DEVICE, BbsCount, (UINT16 *) Ptr);
} }
//
// Save device order for legacy boot device to variable.
//
Status = gRT->SetVariable ( Status = gRT->SetVariable (
VAR_LEGACY_DEV_ORDER, VAR_LEGACY_DEV_ORDER,
&EfiLegacyDevOrderGuid, &EfiLegacyDevOrderGuid,
@ -1535,7 +1520,7 @@ PrintBbsTable (
@param Entry The boot option is to be checked for refresh BBS table. @param Entry The boot option is to be checked for refresh BBS table.
@retval EFI_SUCCESS The boot priority for BBS entries is refreshed successfully. @retval EFI_SUCCESS The boot priority for BBS entries is refreshed successfully.
@return status of BdsSetBootPriority4SameTypeDev()
**/ **/
EFI_STATUS EFI_STATUS
BdsRefreshBbsTableForBoot ( BdsRefreshBbsTableForBoot (

6
MdeModulePkg/Universal/BdsDxe/BootMaint/BBSsupport.h
View File

@ -56,9 +56,6 @@ BdsDeleteAllInvalidLegacyBootOptions (
Add the legacy boot options from BBS table if they do not exist. Add the legacy boot options from BBS table if they do not exist.
@retval EFI_SUCCESS The boot options are added successfully or they are already in boot options. @retval EFI_SUCCESS The boot options are added successfully or they are already in boot options.
@retval others An error occurred when creating legacy boot options. @retval others An error occurred when creating legacy boot options.
@ -83,13 +80,12 @@ BdsUpdateLegacyDevOrder (
); );
/** /**
Set the boot priority for BBS entries based on boot option entry and boot order. Set the boot priority for BBS entries based on boot option entry and boot order.
@param Entry The boot option is to be checked for refresh BBS table. @param Entry The boot option is to be checked for refresh BBS table.
@retval EFI_SUCCESS The boot priority for BBS entries is refreshed successfully. @retval EFI_SUCCESS The boot priority for BBS entries is refreshed successfully.
@return status of BdsSetBootPriority4SameTypeDev()
**/ **/
EFI_STATUS EFI_STATUS
BdsRefreshBbsTableForBoot ( BdsRefreshBbsTableForBoot (

10
MdeModulePkg/Universal/BdsDxe/BootMaint/BmLib.c
View File

@ -48,8 +48,7 @@ EfiLibLocateProtocol (
Function opens and returns a file handle to the root directory of a volume. Function opens and returns a file handle to the root directory of a volume.
@param DeviceHandle A handle for a device
@param DeviceHandle - A handle for a device
@return A valid file handle or NULL is returned @return A valid file handle or NULL is returned
@ -96,9 +95,9 @@ EfiLibOpenRoot (
EFI interfaces. EFI interfaces.
@param Status - Current status @param Status Current status
@param Buffer - Current allocated buffer, or NULL @param Buffer Current allocated buffer, or NULL
@param BufferSize - Current buffer size needed @param BufferSize Current buffer size needed
@retval TRUE if the buffer was reallocated and the caller @retval TRUE if the buffer was reallocated and the caller
should try the API again. should try the API again.
@ -173,7 +172,6 @@ EfiLibGetVariable (
/** /**
Function deletes the variable specified by VarName and VarGuid. Function deletes the variable specified by VarName and VarGuid.
@param VarName A Null-terminated Unicode string that is @param VarName A Null-terminated Unicode string that is
the name of the vendor's variable. the name of the vendor's variable.

17
MdeModulePkg/Universal/BdsDxe/BootMaint/BootMaint.c
View File

@ -102,14 +102,14 @@ CreateMenuStringToken (
or more named elements from the target driver. or more named elements from the target driver.
@param This - Points to the EFI_HII_CONFIG_ACCESS_PROTOCOL. @param This Points to the EFI_HII_CONFIG_ACCESS_PROTOCOL.
@param Request - A null-terminated Unicode string in <ConfigRequest> format. @param Request A null-terminated Unicode string in <ConfigRequest> format.
@param Progress - On return, points to a character in the Request string. @param Progress On return, points to a character in the Request string.
Points to the string's null terminator if request was successful. Points to the string's null terminator if request was successful.
Points to the most recent '&' before the first failing name/value Points to the most recent '&' before the first failing name/value
pair (or the beginning of the string if the failure is in the pair (or the beginning of the string if the failure is in the
first name/value pair) if the request was not successful. first name/value pair) if the request was not successful.
@param Results - A null-terminated Unicode string in <ConfigAltResp> format which @param Results A null-terminated Unicode string in <ConfigAltResp> format which
has all values filled in for the names in the Request string. has all values filled in for the names in the Request string.
String to be allocated by the called function. String to be allocated by the called function.
@ -540,10 +540,9 @@ BootMaintCallback (
/** /**
Function handling request to apply changes for BMM pages. Function handling request to apply changes for BMM pages.
@param Private Pointer to callback data buffer.
@param Private - Pointer to callback data buffer. @param CurrentFakeNVMap Pointer to buffer holding data of various values used by BMM
@param CurrentFakeNVMap - Pointer to buffer holding data of various values used by BMM @param FormId ID of the form which has sent the request to apply change.
@param FormId - ID of the form which has sent the request to apply change.
@retval EFI_SUCCESS Change successfully applied. @retval EFI_SUCCESS Change successfully applied.
@retval Other Error occurs while trying to apply changes. @retval Other Error occurs while trying to apply changes.
@ -731,8 +730,6 @@ Error:
@param Private The BMM context data. @param Private The BMM context data.
@param CurrentFakeNVMap The current Fack NV Map. @param CurrentFakeNVMap The current Fack NV Map.
**/ **/
VOID VOID
DiscardChangeHandler ( DiscardChangeHandler (

59
MdeModulePkg/Universal/BdsDxe/BootMaint/BootMaint.h
View File

@ -278,13 +278,11 @@ typedef enum {
#define STRING_DEPOSITORY_NUMBER 8 #define STRING_DEPOSITORY_NUMBER 8
// ///
// #pragma pack(1) /// Serial Ports attributes, first one is the value for
// /// return from callback function, stringtoken is used to
// Serial Ports attributes, first one is the value for /// display the value properly
// return from callback function, stringtoken is used to ///
// display the value properly
//
typedef struct { typedef struct {
UINTN Value; UINTN Value;
UINT16 StringToken; UINT16 StringToken;
@ -498,8 +496,6 @@ BOpt_FindFiles (
All valid handles in the system except those consume SimpleFs, LoadFile All valid handles in the system except those consume SimpleFs, LoadFile
are stored in DriverMenu for future use. are stored in DriverMenu for future use.
@retval EFI_SUCCESS The function complets successfully. @retval EFI_SUCCESS The function complets successfully.
@return Other value if failed to build the DriverMenu. @return Other value if failed to build the DriverMenu.
@ -637,8 +633,6 @@ BOpt_IsEfiApp (
Get the Option Number that has not been allocated for use. Get the Option Number that has not been allocated for use.
@return The available Option Number. @return The available Option Number.
**/ **/
@ -651,8 +645,6 @@ BOpt_GetBootOptionNumber (
Get the Option Number that is not in use. Get the Option Number that is not in use.
@return The unused Option Number. @return The unused Option Number.
**/ **/
@ -1315,26 +1307,6 @@ EfiLibFileInfo (
IN EFI_FILE_HANDLE FHand IN EFI_FILE_HANDLE FHand
); );
/**
change a Unicode string t ASCII string
@param UStr Unicode string
Lenght - most possible length of AStr
@param Length The length of UStr.
@param AStr ASCII string to pass out
@return Actual length
**/
UINTN
UnicodeToAscii (
IN CHAR16 *UStr,
IN UINTN Length,
OUT CHAR8 *AStr
);
/** /**
This function converts an input device structure to a Unicode string. This function converts an input device structure to a Unicode string.
@ -1542,11 +1514,6 @@ BdsStartBootMaint (
/** /**
Intialize all the string depositories. Intialize all the string depositories.
**/ **/
VOID VOID
InitializeStringDepository ( InitializeStringDepository (
@ -1571,12 +1538,6 @@ GetStringTokenFromDepository (
/** /**
Reclaim string depositories by moving the current node pointer to list head.. Reclaim string depositories by moving the current node pointer to list head..
**/ **/
VOID VOID
ReclaimStringDepository ( ReclaimStringDepository (
@ -1586,11 +1547,6 @@ ReclaimStringDepository (
/** /**
Release resource for all the string depositories. Release resource for all the string depositories.
**/ **/
VOID VOID
CleanUpStringDepository ( CleanUpStringDepository (
@ -1623,8 +1579,6 @@ ApplyChangeHandler (
@param Private The BMM context data. @param Private The BMM context data.
@param CurrentFakeNVMap The current Fack NV Map. @param CurrentFakeNVMap The current Fack NV Map.
**/ **/
VOID VOID
DiscardChangeHandler ( DiscardChangeHandler (
@ -1638,8 +1592,6 @@ DiscardChangeHandler (
@param Private The BMM context data. @param Private The BMM context data.
@param NewPageId The original page ID. @param NewPageId The original page ID.
**/ **/
VOID VOID
UpdatePageId ( UpdatePageId (
@ -1736,7 +1688,6 @@ FormSetDispatcher (
/** /**
Function returns the value of the specified variable. Function returns the value of the specified variable.
@param Name A Null-terminated Unicode string that is @param Name A Null-terminated Unicode string that is
the name of the vendor's variable. the name of the vendor's variable.
@param VendorGuid A unique identifier for the vendor. @param VendorGuid A unique identifier for the vendor.

30
MdeModulePkg/Universal/BdsDxe/BootMaint/BootOption.c
View File

@ -24,7 +24,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
@param MenuType The Menu type to be created. @param MenuType The Menu type to be created.
@retval NULL If failed to create the menu. @retval NULL If failed to create the menu.
@return The menu. @return The menu.
@ -37,6 +36,9 @@ BOpt_CreateMenuEntry (
BM_MENU_ENTRY *MenuEntry; BM_MENU_ENTRY *MenuEntry;
UINTN ContextSize; UINTN ContextSize;
//
// Get context size according to menu type
//
switch (MenuType) { switch (MenuType) {
case BM_LOAD_CONTEXT_SELECT: case BM_LOAD_CONTEXT_SELECT:
ContextSize = sizeof (BM_LOAD_CONTEXT); ContextSize = sizeof (BM_LOAD_CONTEXT);
@ -65,13 +67,15 @@ BOpt_CreateMenuEntry (
default: default:
ContextSize = 0; ContextSize = 0;
break; break;
} }
if (0 == ContextSize) { if (ContextSize == 0) {
return NULL; return NULL;
} }
//
// Create new menu entry
//
MenuEntry = AllocateZeroPool (sizeof (BM_MENU_ENTRY)); MenuEntry = AllocateZeroPool (sizeof (BM_MENU_ENTRY));
if (NULL == MenuEntry) { if (NULL == MenuEntry) {
return MenuEntry; return MenuEntry;
@ -80,8 +84,7 @@ BOpt_CreateMenuEntry (
MenuEntry->VariableContext = AllocateZeroPool (ContextSize); MenuEntry->VariableContext = AllocateZeroPool (ContextSize);
if (NULL == MenuEntry->VariableContext) { if (NULL == MenuEntry->VariableContext) {
SafeFreePool (MenuEntry); SafeFreePool (MenuEntry);
MenuEntry = NULL; return NULL;
return MenuEntry;
} }
MenuEntry->Signature = BM_MENU_ENTRY_SIGNATURE; MenuEntry->Signature = BM_MENU_ENTRY_SIGNATURE;
@ -94,8 +97,6 @@ BOpt_CreateMenuEntry (
@param MenuEntry A pointer to BM_MENU_ENTRY. @param MenuEntry A pointer to BM_MENU_ENTRY.
@retval VOID
**/ **/
VOID VOID
BOpt_DestroyMenuEntry ( BOpt_DestroyMenuEntry (
@ -504,9 +505,6 @@ BOpt_FindFileSystem (
Free resources allocated in Allocate Rountine. Free resources allocated in Allocate Rountine.
@param FreeMenu Menu to be freed @param FreeMenu Menu to be freed
**/ **/
VOID VOID
BOpt_FreeMenu ( BOpt_FreeMenu (
@ -685,8 +683,6 @@ BOpt_FindFiles (
/** /**
Build the LegacyFDMenu LegacyHDMenu LegacyCDMenu according to LegacyBios.GetBbsInfo(). Build the LegacyFDMenu LegacyHDMenu LegacyCDMenu according to LegacyBios.GetBbsInfo().
@retval EFI_SUCCESS The function complete successfully. @retval EFI_SUCCESS The function complete successfully.
@retval EFI_OUT_OF_RESOURCES No enough memory to complete this function. @retval EFI_OUT_OF_RESOURCES No enough memory to complete this function.
@ -825,10 +821,6 @@ BOpt_GetLegacyOptions (
/** /**
Free out resouce allocated from Legacy Boot Options. Free out resouce allocated from Legacy Boot Options.
.
**/ **/
VOID VOID
BOpt_FreeLegacyOptions ( BOpt_FreeLegacyOptions (
@ -1243,8 +1235,6 @@ BOpt_IsEfiApp (
All valid handles in the system except those consume SimpleFs, LoadFile All valid handles in the system except those consume SimpleFs, LoadFile
are stored in DriverMenu for future use. are stored in DriverMenu for future use.
@retval EFI_SUCCESS The function complets successfully. @retval EFI_SUCCESS The function complets successfully.
@return Other value if failed to build the DriverMenu. @return Other value if failed to build the DriverMenu.
@ -1334,8 +1324,6 @@ BOpt_FindDrivers (
Get the Option Number that has not been allocated for use. Get the Option Number that has not been allocated for use.
@return The available Option Number. @return The available Option Number.
**/ **/
@ -1410,8 +1398,6 @@ BOpt_GetBootOptionNumber (
Get the Option Number that is not in use. Get the Option Number that is not in use.
@return The unused Option Number. @return The unused Option Number.
**/ **/

23
MdeModulePkg/Universal/BdsDxe/BootMaint/ConsoleOption.c
View File

@ -170,9 +170,7 @@ ChangeTerminalDevicePath (
based on the new BaudRate, Data Bits, parity and Stop Bits based on the new BaudRate, Data Bits, parity and Stop Bits
set. set.
@param DevicePath @param DevicePath terminal device's path
**/ **/
VOID VOID
@ -235,14 +233,11 @@ ChangeVariableDevicePath (
Node = NextDevicePathNode (Node); Node = NextDevicePathNode (Node);
} }
return ;
} }
/** /**
Retrieve ACPI UID of UART from device path Retrieve ACPI UID of UART from device path
@param Handle The handle for the UART device. @param Handle The handle for the UART device.
@param AcpiUid The ACPI UID on output. @param AcpiUid The ACPI UID on output.
@ -289,12 +284,8 @@ RetrieveUartUid (
/** /**
Sort Uart handles array with Acpi->UID from low to high. Sort Uart handles array with Acpi->UID from low to high.
@param Handles EFI_SERIAL_IO_PROTOCOL handle buffer @param Handles EFI_SERIAL_IO_PROTOCOL handle buffer
@param NoHandles EFI_SERIAL_IO_PROTOCOL handle count @param NoHandles EFI_SERIAL_IO_PROTOCOL handle count
@retval VOID
**/ **/
VOID VOID
SortedUartHandle ( SortedUartHandle (
@ -558,7 +549,7 @@ LocateSerialIo (
@param DevicePath DevicePath that contains Com ports @param DevicePath DevicePath that contains Com ports
@retval EFI_SUCCESS The update is successful. @retval EFI_SUCCESS The update is successful.
@retval EFI_NOT_FOUND Can not find specific menu entry
**/ **/
EFI_STATUS EFI_STATUS
UpdateComAttributeFromVariable ( UpdateComAttributeFromVariable (
@ -857,9 +848,6 @@ GetConsoleMenu (
/** /**
Build up ConsoleOutMenu, ConsoleInpMenu and ConsoleErrMenu Build up ConsoleOutMenu, ConsoleInpMenu and ConsoleErrMenu
@retval EFI_SUCCESS The function always complete successfully. @retval EFI_SUCCESS The function always complete successfully.
**/ **/
@ -877,9 +865,6 @@ GetAllConsoles (
/** /**
Free ConsoleOutMenu, ConsoleInpMenu and ConsoleErrMenu Free ConsoleOutMenu, ConsoleInpMenu and ConsoleErrMenu
EDES_TODO: Add parameter description
@retval EFI_SUCCESS The function always complete successfully. @retval EFI_SUCCESS The function always complete successfully.
**/ **/
EFI_STATUS EFI_STATUS
@ -981,11 +966,7 @@ IsTerminalDevicePath (
/** /**
Get mode number according to column and row Get mode number according to column and row
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
GetConsoleOutMode ( GetConsoleOutMode (

114
MdeModulePkg/Universal/BdsDxe/BootMaint/Data.c
View File

@ -23,9 +23,9 @@ STRING_DEPOSITORY *DriverOptionStrDepository;
STRING_DEPOSITORY *DriverOptionHelpStrDepository; STRING_DEPOSITORY *DriverOptionHelpStrDepository;
STRING_DEPOSITORY *TerminalStrDepository; STRING_DEPOSITORY *TerminalStrDepository;
// ///
// Terminal type string token storage /// Terminal type string token storage
// ///
UINT16 TerminalType[] = { UINT16 TerminalType[] = {
STRING_TOKEN(STR_COM_TYPE_0), STRING_TOKEN(STR_COM_TYPE_0),
STRING_TOKEN(STR_COM_TYPE_1), STRING_TOKEN(STR_COM_TYPE_1),
@ -33,117 +33,117 @@ UINT16 TerminalType[] = {
STRING_TOKEN(STR_COM_TYPE_3), STRING_TOKEN(STR_COM_TYPE_3),
}; };
// ///
// File system selection menu /// File system selection menu
// ///
BM_MENU_OPTION FsOptionMenu = { BM_MENU_OPTION FsOptionMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Console Input Device Selection Menu /// Console Input Device Selection Menu
// ///
BM_MENU_OPTION ConsoleInpMenu = { BM_MENU_OPTION ConsoleInpMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Console Output Device Selection Menu /// Console Output Device Selection Menu
// ///
BM_MENU_OPTION ConsoleOutMenu = { BM_MENU_OPTION ConsoleOutMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Error Output Device Selection Menu /// Error Output Device Selection Menu
// ///
BM_MENU_OPTION ConsoleErrMenu = { BM_MENU_OPTION ConsoleErrMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Boot Option from variable Menu /// Boot Option from variable Menu
// ///
BM_MENU_OPTION BootOptionMenu = { BM_MENU_OPTION BootOptionMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Driver Option from variable menu /// Driver Option from variable menu
// ///
BM_MENU_OPTION DriverOptionMenu = { BM_MENU_OPTION DriverOptionMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Legacy FD Info from LegacyBios.GetBbsInfo() /// Legacy FD Info from LegacyBios.GetBbsInfo()
// ///
BM_MENU_OPTION LegacyFDMenu = { BM_MENU_OPTION LegacyFDMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Legacy HD Info from LegacyBios.GetBbsInfo() /// Legacy HD Info from LegacyBios.GetBbsInfo()
// ///
BM_MENU_OPTION LegacyHDMenu = { BM_MENU_OPTION LegacyHDMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Legacy CD Info from LegacyBios.GetBbsInfo() /// Legacy CD Info from LegacyBios.GetBbsInfo()
// ///
BM_MENU_OPTION LegacyCDMenu = { BM_MENU_OPTION LegacyCDMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Legacy NET Info from LegacyBios.GetBbsInfo() /// Legacy NET Info from LegacyBios.GetBbsInfo()
// ///
BM_MENU_OPTION LegacyNETMenu = { BM_MENU_OPTION LegacyNETMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Legacy NET Info from LegacyBios.GetBbsInfo() /// Legacy NET Info from LegacyBios.GetBbsInfo()
// ///
BM_MENU_OPTION LegacyBEVMenu = { BM_MENU_OPTION LegacyBEVMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Files and sub-directories in current directory menu /// Files and sub-directories in current directory menu
// ///
BM_MENU_OPTION DirectoryMenu = { BM_MENU_OPTION DirectoryMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
0 0
}; };
// ///
// Handles in current system selection menu /// Handles in current system selection menu
// ///
BM_MENU_OPTION DriverMenu = { BM_MENU_OPTION DriverMenu = {
BM_MENU_OPTION_SIGNATURE, BM_MENU_OPTION_SIGNATURE,
NULL, NULL,
@ -156,9 +156,9 @@ BM_MENU_OPTION TerminalMenu = {
0 0
}; };
// ///
// Value and string token correspondency for BaudRate /// Value and string token correspondency for BaudRate
// ///
COM_ATTR BaudRateList[19] = { COM_ATTR BaudRateList[19] = {
{ {
115200, 115200,
@ -238,9 +238,9 @@ COM_ATTR BaudRateList[19] = {
} }
}; };
// ///
// Value and string token correspondency for DataBits /// Value and string token correspondency for DataBits
// ///
COM_ATTR DataBitsList[4] = { COM_ATTR DataBitsList[4] = {
{ {
5, 5,
@ -260,9 +260,9 @@ COM_ATTR DataBitsList[4] = {
} }
}; };
// ///
// Value and string token correspondency for Parity /// Value and string token correspondency for Parity
// ///
COM_ATTR ParityList[5] = { COM_ATTR ParityList[5] = {
{ {
NoParity, NoParity,
@ -286,9 +286,9 @@ COM_ATTR ParityList[5] = {
} }
}; };
// ///
// Value and string token correspondency for Baudreate /// Value and string token correspondency for Baudreate
// ///
COM_ATTR StopBitsList[3] = { COM_ATTR StopBitsList[3] = {
{ {
OneStopBit, OneStopBit,
@ -304,9 +304,9 @@ COM_ATTR StopBitsList[3] = {
} }
}; };
// ///
// Guid for messaging path, used in Serial port setting. /// Guid for messaging path, used in Serial port setting.
// ///
EFI_GUID TerminalTypeGuid[4] = { EFI_GUID TerminalTypeGuid[4] = {
DEVICE_PATH_MESSAGING_PC_ANSI, DEVICE_PATH_MESSAGING_PC_ANSI,
DEVICE_PATH_MESSAGING_VT_100, DEVICE_PATH_MESSAGING_VT_100,

3
MdeModulePkg/Universal/BdsDxe/BootMaint/FileExplorer.c
View File

@ -17,12 +17,9 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
/** /**
Update the File Explore page. Update the File Explore page.
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
@param MenuOption Pointer to menu options to display. @param MenuOption Pointer to menu options to display.
**/ **/
VOID VOID
UpdateFileExplorePage ( UpdateFileExplorePage (

22
MdeModulePkg/Universal/BdsDxe/BootMaint/FormGuid.h
View File

@ -82,14 +82,14 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#define VARSTORE_ID_BOOT_MAINT 0x1000 #define VARSTORE_ID_BOOT_MAINT 0x1000
#define VARSTORE_ID_FILE_EXPLORER 0x1001 #define VARSTORE_ID_FILE_EXPLORER 0x1001
// ///
// This is the structure that will be used to store the /// This is the structure that will be used to store the
// question's current value. Use it at initialize time to /// question's current value. Use it at initialize time to
// set default value for each question. When using at run /// set default value for each question. When using at run
// time, this map is returned by the callback function, /// time, this map is returned by the callback function,
// so dynamically changing the question's value will be /// so dynamically changing the question's value will be
// possible through this mechanism /// possible through this mechanism
// ///
typedef struct { typedef struct {
// //
// Three questions displayed at the main page // Three questions displayed at the main page
@ -195,9 +195,9 @@ typedef struct {
#define KEY_VALUE_SAVE_AND_EXIT_DRIVER 0x1002 #define KEY_VALUE_SAVE_AND_EXIT_DRIVER 0x1002
#define KEY_VALUE_NO_SAVE_AND_EXIT_DRIVER 0x1003 #define KEY_VALUE_NO_SAVE_AND_EXIT_DRIVER 0x1003
// ///
// This is the data structure used by File Explorer formset /// This is the data structure used by File Explorer formset
// ///
typedef struct { typedef struct {
UINT16 DescriptionData[75]; UINT16 DescriptionData[75];
UINT16 OptionalData[127]; UINT16 OptionalData[127];

43
MdeModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c
View File

@ -17,10 +17,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
/** /**
Refresh the global UpdateData structure. Refresh the global UpdateData structure.
**/ **/
VOID VOID
RefreshUpdateData ( RefreshUpdateData (
@ -34,11 +30,8 @@ RefreshUpdateData (
Add a "Go back to main page" tag in front of the form when there are no Add a "Go back to main page" tag in front of the form when there are no
"Apply changes" and "Discard changes" tags in the end of the form. "Apply changes" and "Discard changes" tags in the end of the form.
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdatePageStart ( UpdatePageStart (
@ -70,8 +63,6 @@ UpdatePageStart (
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdatePageEnd ( UpdatePageEnd (
@ -130,8 +121,6 @@ UpdatePageEnd (
opcode deletion. opcode deletion.
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
CleanUpPage ( CleanUpPage (
@ -202,9 +191,6 @@ BootThisFile (
by TerminaMenu. This list will be inserted to form FORM_CON_COM_SETUP_ID. by TerminaMenu. This list will be inserted to form FORM_CON_COM_SETUP_ID.
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateConCOMPage ( UpdateConCOMPage (
@ -241,8 +227,6 @@ UpdateConCOMPage (
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateBootDelPage ( UpdateBootDelPage (
@ -288,8 +272,6 @@ UpdateBootDelPage (
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateDrvAddHandlePage ( UpdateDrvAddHandlePage (
@ -323,11 +305,8 @@ UpdateDrvAddHandlePage (
Create a lit of driver option from global DriverOptionMenu. It Create a lit of driver option from global DriverOptionMenu. It
allow user to delete the driver option. allow user to delete the driver option.
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateDrvDelPage ( UpdateDrvDelPage (
@ -372,8 +351,6 @@ UpdateDrvDelPage (
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateDriverAddHandleDescPage ( UpdateDriverAddHandleDescPage (
@ -444,8 +421,6 @@ UpdateDriverAddHandleDescPage (
@param ConsoleMenu The console menu list. @param ConsoleMenu The console menu list.
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateConsolePage ( UpdateConsolePage (
@ -528,8 +503,6 @@ UpdateConsolePage (
@param OptionMenu The new list. @param OptionMenu The new list.
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateOrderPage ( UpdateOrderPage (
@ -597,8 +570,6 @@ UpdateOrderPage (
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateBootNextPage ( UpdateBootNextPage (
@ -671,8 +642,6 @@ UpdateBootNextPage (
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateTimeOutPage ( UpdateTimeOutPage (
@ -710,11 +679,8 @@ UpdateTimeOutPage (
/** /**
Refresh the text mode page Refresh the text mode page
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateConModePage ( UpdateConModePage (
@ -822,8 +788,6 @@ UpdateConModePage (
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateTerminalPage ( UpdateTerminalPage (
@ -998,8 +962,6 @@ UpdateTerminalPage (
@param UpdatePageId The form ID. @param UpdatePageId The form ID.
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdatePageBody ( UpdatePageBody (
@ -1043,8 +1005,6 @@ UpdatePageBody (
@param OptionIndex Returns the index number (#### in Boot####). @param OptionIndex Returns the index number (#### in Boot####).
@param OptionSize Return the size of the Boot### variable. @param OptionSize Return the size of the Boot### variable.
**/ **/
VOID * VOID *
GetLegacyBootOptionVar ( GetLegacyBootOptionVar (
@ -1126,7 +1086,6 @@ GetLegacyBootOptionVar (
@param CallbackData The BMM context data. @param CallbackData The BMM context data.
**/ **/
VOID VOID
UpdateSetLegacyDeviceOrderPage ( UpdateSetLegacyDeviceOrderPage (
@ -1329,8 +1288,6 @@ UpdateSetLegacyDeviceOrderPage (
@param Private The BMM context data. @param Private The BMM context data.
@param NewPageId The original page ID. @param NewPageId The original page ID.
**/ **/
VOID VOID
UpdatePageId ( UpdatePageId (

21
MdeModulePkg/Universal/BdsDxe/BootMaint/Variable.c
View File

@ -176,9 +176,6 @@ Var_ChangeBootOrder (
After deleting this Driver option, call Var_ChangeDriverOrder to After deleting this Driver option, call Var_ChangeDriverOrder to
make sure DriverOrder is in valid state. make sure DriverOrder is in valid state.
@retval EFI_SUCCESS Load Option is successfully updated. @retval EFI_SUCCESS Load Option is successfully updated.
@return Other value than EFI_SUCCESS if failed to update "Driver Order" EFI @return Other value than EFI_SUCCESS if failed to update "Driver Order" EFI
Variable. Variable.
@ -237,9 +234,6 @@ Var_DelDriverOption (
rebuild DriverOrder from scratch by content from DriverOptionMenu is rebuild DriverOrder from scratch by content from DriverOptionMenu is
needed. needed.
@retval EFI_SUCCESS The driver order is updated successfully. @retval EFI_SUCCESS The driver order is updated successfully.
@return EFI_STATUS other than EFI_SUCCESS if failed to @return EFI_STATUS other than EFI_SUCCESS if failed to
Set the "DriverOrder" EFI Variable. Set the "DriverOrder" EFI Variable.
@ -320,10 +314,6 @@ Var_ChangeDriverOrder (
based on the new BaudRate, Data Bits, parity and Stop Bits based on the new BaudRate, Data Bits, parity and Stop Bits
set. set.
**/ **/
VOID VOID
Var_UpdateAllConsoleOption ( Var_UpdateAllConsoleOption (
@ -486,9 +476,6 @@ Var_UpdateConsoleOption (
This function delete and build multi-instance device path ConIn This function delete and build multi-instance device path ConIn
console device. console device.
@retval EFI_SUCCESS The function complete successfully. @retval EFI_SUCCESS The function complete successfully.
@return The EFI variable can be saved. See gRT->SetVariable @return The EFI variable can be saved. See gRT->SetVariable
for detail return information. for detail return information.
@ -505,9 +492,6 @@ Var_UpdateConsoleInpOption (
This function delete and build multi-instance device path ConOut This function delete and build multi-instance device path ConOut
console device. console device.
@retval EFI_SUCCESS The function complete successfully. @retval EFI_SUCCESS The function complete successfully.
@return The EFI variable can be saved. See gRT->SetVariable @return The EFI variable can be saved. See gRT->SetVariable
for detail return information. for detail return information.
@ -524,9 +508,6 @@ Var_UpdateConsoleOutOption (
This function delete and build multi-instance device path ErrOut This function delete and build multi-instance device path ErrOut
console device. console device.
@retval EFI_SUCCESS The function complete successfully. @retval EFI_SUCCESS The function complete successfully.
@return The EFI variable can be saved. See gRT->SetVariable @return The EFI variable can be saved. See gRT->SetVariable
for detail return information. for detail return information.
@ -1272,7 +1253,7 @@ Var_UpdateBBSOption (
StrSize (LegacyDeviceContext->Description) StrSize (LegacyDeviceContext->Description)
); );
UnicodeToAscii (DescString, StrSize (DescString), DescAsciiString); UnicodeStrToAsciiStr((CONST CHAR16*)&DescString, (CHAR8 *)&DescAsciiString);
NewOptionSize = sizeof (UINT32) + sizeof (UINT16) + StrSize (DescString) + NewOptionSize = sizeof (UINT32) + sizeof (UINT16) + StrSize (DescString) +
sizeof (BBS_BBS_DEVICE_PATH); sizeof (BBS_BBS_DEVICE_PATH);

3
MdeModulePkg/Universal/BdsDxe/BootMngr/BootManager.c
View File

@ -104,8 +104,7 @@ BootManagerCallback (
Registers HII packages for the Boot Manger to HII Database. Registers HII packages for the Boot Manger to HII Database.
It also registers the browser call back function. It also registers the browser call back function.
@return Status of HiiLibCreateHiiDriverHandle() and gHiiDatabase->NewPackageList()
@return EDES_TODO: Add description for return value
**/ **/
EFI_STATUS EFI_STATUS

4
MdeModulePkg/Universal/BdsDxe/BootMngr/BootManager.h
View File

@ -87,9 +87,7 @@ BootManagerCallback (
Registers HII packages for the Boot Manger to HII Database. Registers HII packages for the Boot Manger to HII Database.
It also registers the browser call back function. It also registers the browser call back function.
@return Status of HiiLibCreateHiiDriverHandle() and gHiiDatabase->NewPackageList()
@return EDES_TODO: Add description for return value
**/ **/
EFI_STATUS EFI_STATUS
InitializeBootManager ( InitializeBootManager (

3
MdeModulePkg/Universal/BdsDxe/Capsules.c
View File

@ -19,8 +19,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
@param CpuIo A instance of EFI_CPU_IO_PROTOCOL. @param CpuIo A instance of EFI_CPU_IO_PROTOCOL.
@param Base The base address flash region to be locked. @param Base The base address flash region to be locked.
@return VOID No return.
**/ **/
VOID VOID
BdsLockFv ( BdsLockFv (
@ -82,6 +80,7 @@ BdsLockFv (
need to do this if an earlier update went awry and we need to need to do this if an earlier update went awry and we need to
clear the capsule variable so on the next reset PEI does not see it and clear the capsule variable so on the next reset PEI does not see it and
think there is a capsule available. think there is a capsule available.
@retval EFI_SUCCESS There is no error when processing capsule
**/ **/
EFI_STATUS EFI_STATUS

3
MdeModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c
View File

@ -114,7 +114,6 @@ DeviceManagerCallback (
This function registers HII packages to HII database. This function registers HII packages to HII database.
@retval EFI_SUCCESS This function complete successfully. @retval EFI_SUCCESS This function complete successfully.
@return Other value if failed to register HII packages. @return Other value if failed to register HII packages.
@ -171,8 +170,6 @@ InitializeDeviceManager (
This function create the dynamic content for device manager. It includes This function create the dynamic content for device manager. It includes
section header for all class of devices, one-of opcode to set VBIOS. section header for all class of devices, one-of opcode to set VBIOS.
@retval EFI_SUCCESS Operation is successful. @retval EFI_SUCCESS Operation is successful.
@retval Other values if failed to clean up the dynamic content from HII @retval Other values if failed to clean up the dynamic content from HII
database. database.

56
MdeModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.h
View File

@ -43,20 +43,20 @@ extern UINT8 DeviceManagerVfrBin[];
typedef struct { typedef struct {
UINTN Signature; UINTN Signature;
// ///
// HII relative handles /// HII relative handles
// ///
EFI_HII_HANDLE HiiHandle; EFI_HII_HANDLE HiiHandle;
EFI_HANDLE DriverHandle; EFI_HANDLE DriverHandle;
// ///
// Produced protocols /// Produced protocols
// ///
EFI_HII_CONFIG_ACCESS_PROTOCOL ConfigAccess; EFI_HII_CONFIG_ACCESS_PROTOCOL ConfigAccess;
// ///
// Configuration data /// Configuration data
// ///
UINT8 VideoBios; UINT8 VideoBios;
} DEVICE_MANAGER_CALLBACK_DATA; } DEVICE_MANAGER_CALLBACK_DATA;
@ -72,16 +72,21 @@ typedef struct {
} DEVICE_MANAGER_MENU_ITEM; } DEVICE_MANAGER_MENU_ITEM;
/** /**
EDES_TODO: Add function description. This function is invoked if user selected a iteractive opcode from Device Manager's
Formset. The decision by user is saved to gCallbackKey for later processing. If
user set VBIOS, the new value is saved to EFI variable.
@param This EDES_TODO: Add parameter description
@param Action EDES_TODO: Add parameter description
@param QuestionId EDES_TODO: Add parameter description
@param Type EDES_TODO: Add parameter description
@param Value EDES_TODO: Add parameter description
@param ActionRequest EDES_TODO: Add parameter description
@return EDES_TODO: Add description for return value @param This Points to the EFI_HII_CONFIG_ACCESS_PROTOCOL.
@param Action Specifies the type of action taken by the browser.
@param QuestionId A unique value which is sent to the original exporting driver
so that it can identify the type of data to expect.
@param Type The type of value for the question.
@param Value A pointer to the data being sent to the original exporting driver.
@param ActionRequest On return, points to the action requested by the callback function.
@retval EFI_SUCCESS The callback successfully handled the action.
@retval EFI_INVALID_PARAMETER The setup browser call this function with invalid parameters.
**/ **/
EFI_STATUS EFI_STATUS
@ -97,11 +102,11 @@ DeviceManagerCallback (
; ;
/** /**
EDES_TODO: Add function description.
@param VOID EDES_TODO: Add parameter description This function registers HII packages to HII database.
@return EDES_TODO: Add description for return value @retval EFI_SUCCESS This function complete successfully.
@return Other value if failed to register HII packages.
**/ **/
EFI_STATUS EFI_STATUS
@ -111,11 +116,16 @@ InitializeDeviceManager (
; ;
/** /**
EDES_TODO: Add function description.
@param VOID EDES_TODO: Add parameter description Call the browser and display the device manager to allow user
to configure the platform.
@return EDES_TODO: Add description for return value This function create the dynamic content for device manager. It includes
section header for all class of devices, one-of opcode to set VBIOS.
@retval EFI_SUCCESS Operation is successful.
@retval Other values if failed to clean up the dynamic content from HII
database.
**/ **/
EFI_STATUS EFI_STATUS

5
MdeModulePkg/Universal/BdsDxe/FrontPage.c
View File

@ -447,9 +447,6 @@ InitializeFrontPage (
/** /**
Call the browser and display the front page Call the browser and display the front page
@param VOID No input.
@return Status code that will be returned by @return Status code that will be returned by
EFI_FORM_BROWSER2_PROTOCOL.SendForm (). EFI_FORM_BROWSER2_PROTOCOL.SendForm ().
@ -573,8 +570,6 @@ ConvertProcessorToString (
@param MemorySize - The size of the memory to process @param MemorySize - The size of the memory to process
@param String - The string that is created @param String - The string that is created
@return VOID.
**/ **/
VOID VOID
ConvertMemorySizeToString ( ConvertMemorySizeToString (

2
MdeModulePkg/Universal/BdsDxe/FrontPage.h
View File

@ -229,8 +229,6 @@ TimeCompare (
@param ConnectAllHappened - The indicater to check if the connect all have @param ConnectAllHappened - The indicater to check if the connect all have
already happended. already happended.
@return VOID.
**/ **/
VOID VOID
PlatformBdsEnterFrontPage ( PlatformBdsEnterFrontPage (

6
MdeModulePkg/Universal/BdsDxe/Hotkey.c
View File

@ -228,7 +228,6 @@ RegisterHotkey (
Delete Key#### for the given Key Option number. Delete Key#### for the given Key Option number.
@param KeyOptionNumber Key option number for Key#### @param KeyOptionNumber Key option number for Key####
@retval EFI_SUCCESS Unregister hotkey successfully. @retval EFI_SUCCESS Unregister hotkey successfully.
@ -634,11 +633,8 @@ HotkeyInsertList (
Process all the "Key####" variables, associate Hotkeys with corresponding Boot Options. Process all the "Key####" variables, associate Hotkeys with corresponding Boot Options.
@param VOID
@retval EFI_SUCCESS Hotkey services successfully initialized. @retval EFI_SUCCESS Hotkey services successfully initialized.
@retval EFI_NOT_FOUND Can not find the "KeyOrder" variable
**/ **/
EFI_STATUS EFI_STATUS
InitializeHotkeyService ( InitializeHotkeyService (

2
MdeModulePkg/Universal/BdsDxe/HwErrRecSupport.c
View File

@ -27,8 +27,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
non-zero value - Indicates that the platform implements Hardware Error non-zero value - Indicates that the platform implements Hardware Error
Record Persistence. Record Persistence.
@return VOID
**/ **/
VOID VOID
InitializeHwErrRecSupport ( InitializeHwErrRecSupport (

2
MdeModulePkg/Universal/BdsDxe/HwErrRecSupport.h
View File

@ -30,8 +30,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
non-zero value - Indicates that the platform implements Hardware Error non-zero value - Indicates that the platform implements Hardware Error
Record Persistence. Record Persistence.
@return VOID
**/ **/
VOID VOID
InitializeHwErrRecSupport ( InitializeHwErrRecSupport (

7
MdeModulePkg/Universal/BdsDxe/Language.c
View File

@ -23,9 +23,9 @@ EFI_GUID mFontPackageGuid = {
}; };
typedef struct { typedef struct {
// ///
// This 4-bytes total array length is required by HiiLibPreparePackageList() /// This 4-bytes total array length is required by HiiLibPreparePackageList()
// ///
UINT32 Length; UINT32 Length;
// //
@ -283,7 +283,6 @@ ExportFonts (
Determine the current language that will be used Determine the current language that will be used
based on language related EFI Variables. based on language related EFI Variables.
@param LangCodesSettingRequired - If required to set LangCode variable @param LangCodesSettingRequired - If required to set LangCode variable
**/ **/

1
MdeModulePkg/Universal/BdsDxe/Language.h
View File

@ -21,7 +21,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
Determine the current language that will be used Determine the current language that will be used
based on language related EFI Variables. based on language related EFI Variables.
@param LangCodesSettingRequired If required to set LangCode variable @param LangCodesSettingRequired If required to set LangCode variable
**/ **/

3
MdeModulePkg/Universal/BdsDxe/String.c
View File

@ -25,9 +25,6 @@ EFI_GUID mBdsStringPackGuid = {
/** /**
Initialize HII global accessor for string support Initialize HII global accessor for string support
@param VOID
@retval EFI_SUCCESS String support initialize success. @retval EFI_SUCCESS String support initialize success.
**/ **/

6
MdeModulePkg/Universal/BdsDxe/String.h
View File

@ -52,9 +52,6 @@ GetStringById (
/** /**
Initialize HII global accessor for string support Initialize HII global accessor for string support
@param VOID
@retval EFI_SUCCESS String support initialize success. @retval EFI_SUCCESS String support initialize success.
**/ **/
@ -66,9 +63,6 @@ InitializeStringSupport (
/** /**
Call the browser and display the front page Call the browser and display the front page
@param VOID No input.
@return Status code that will be returned by @return Status code that will be returned by
EFI_FORM_BROWSER2_PROTOCOL.SendForm (). EFI_FORM_BROWSER2_PROTOCOL.SendForm ().