DynamicTablesPkg: Reduce log output from TableHelperLib

Reduce the log output from Configuration Manager Object Parser
in TableHelperLib by enabling the logs only if DEBUG_INFO is
enabled.

Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
This commit is contained in:
Sami Mujawar 2022-05-25 18:56:25 +01:00 committed by mergify[bot]
parent b697a31a8d
commit 31f0af7964
1 changed files with 14 additions and 14 deletions

View File

@ -1,7 +1,7 @@
/** @file /** @file
Configuration Manager Object parser. Configuration Manager Object parser.
Copyright (c) 2021 - 2022, ARM Limited. All rights reserved.<BR> Copyright (c) 2021 - 2023, ARM Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent SPDX-License-Identifier: BSD-2-Clause-Patent
**/ **/
@ -787,7 +787,7 @@ PrintOemId (
) )
{ {
DEBUG (( DEBUG ((
DEBUG_ERROR, DEBUG_INFO,
(Format != NULL) ? Format : "%C%C%C%C%C%C", (Format != NULL) ? Format : "%C%C%C%C%C%C",
Ptr[0], Ptr[0],
Ptr[1], Ptr[1],
@ -855,7 +855,7 @@ PrintCmObjDesc (
*RemainingSize -= Parser[Index].Length; *RemainingSize -= Parser[Index].Length;
if (*RemainingSize < 0) { if (*RemainingSize < 0) {
DEBUG (( DEBUG ((
DEBUG_ERROR, DEBUG_INFO,
"\nERROR: %a: Buffer overrun\n", "\nERROR: %a: Buffer overrun\n",
Parser[Index].NameStr Parser[Index].NameStr
)); ));
@ -865,11 +865,11 @@ PrintCmObjDesc (
// Indentation // Indentation
for (IndentIndex = 0; IndentIndex < IndentLevel; IndentIndex++) { for (IndentIndex = 0; IndentIndex < IndentLevel; IndentIndex++) {
DEBUG ((DEBUG_ERROR, " ")); DEBUG ((DEBUG_INFO, " "));
} }
DEBUG (( DEBUG ((
DEBUG_ERROR, DEBUG_INFO,
"%-*a :", "%-*a :",
OUTPUT_FIELD_COLUMN_WIDTH - 2 * IndentLevel, OUTPUT_FIELD_COLUMN_WIDTH - 2 * IndentLevel,
Parser[Index].NameStr Parser[Index].NameStr
@ -879,20 +879,20 @@ PrintCmObjDesc (
} else if (Parser[Index].Format != NULL) { } else if (Parser[Index].Format != NULL) {
switch (Parser[Index].Length) { switch (Parser[Index].Length) {
case 1: case 1:
DEBUG ((DEBUG_ERROR, Parser[Index].Format, *(UINT8 *)Data)); DEBUG ((DEBUG_INFO, Parser[Index].Format, *(UINT8 *)Data));
break; break;
case 2: case 2:
DEBUG ((DEBUG_ERROR, Parser[Index].Format, *(UINT16 *)Data)); DEBUG ((DEBUG_INFO, Parser[Index].Format, *(UINT16 *)Data));
break; break;
case 4: case 4:
DEBUG ((DEBUG_ERROR, Parser[Index].Format, *(UINT32 *)Data)); DEBUG ((DEBUG_INFO, Parser[Index].Format, *(UINT32 *)Data));
break; break;
case 8: case 8:
DEBUG ((DEBUG_ERROR, Parser[Index].Format, ReadUnaligned64 (Data))); DEBUG ((DEBUG_INFO, Parser[Index].Format, ReadUnaligned64 (Data)));
break; break;
default: default:
DEBUG (( DEBUG ((
DEBUG_ERROR, DEBUG_INFO,
"\nERROR: %a: CANNOT PARSE THIS FIELD, Field Length = %d\n", "\nERROR: %a: CANNOT PARSE THIS FIELD, Field Length = %d\n",
Parser[Index].NameStr, Parser[Index].NameStr,
Parser[Index].Length Parser[Index].Length
@ -901,7 +901,7 @@ PrintCmObjDesc (
} else if (Parser[Index].SubObjParser != NULL) { } else if (Parser[Index].SubObjParser != NULL) {
SubStructSize = Parser[Index].Length; SubStructSize = Parser[Index].Length;
DEBUG ((DEBUG_ERROR, "\n")); DEBUG ((DEBUG_INFO, "\n"));
PrintCmObjDesc ( PrintCmObjDesc (
Data, Data,
Parser[Index].SubObjParser, Parser[Index].SubObjParser,
@ -912,14 +912,14 @@ PrintCmObjDesc (
} else { } else {
ASSERT (0); ASSERT (0);
DEBUG (( DEBUG ((
DEBUG_ERROR, DEBUG_INFO,
"\nERROR: %a: CANNOT PARSE THIS FIELD, Field Length = %d\n", "\nERROR: %a: CANNOT PARSE THIS FIELD, Field Length = %d\n",
Parser[Index].NameStr, Parser[Index].NameStr,
Parser[Index].Length Parser[Index].Length
)); ));
} }
DEBUG ((DEBUG_ERROR, "\n")); DEBUG ((DEBUG_INFO, "\n"));
Data = (UINT8 *)Data + Parser[Index].Length; Data = (UINT8 *)Data + Parser[Index].Length;
} // for } // for
} }
@ -978,7 +978,7 @@ ParseCmObjDesc (
for (ObjIndex = 0; ObjIndex < ObjectCount; ObjIndex++) { for (ObjIndex = 0; ObjIndex < ObjectCount; ObjIndex++) {
DEBUG (( DEBUG ((
DEBUG_ERROR, DEBUG_INFO,
"\n%-*a [%d/%d]:\n", "\n%-*a [%d/%d]:\n",
OUTPUT_FIELD_COLUMN_WIDTH, OUTPUT_FIELD_COLUMN_WIDTH,
ParserArray->ObjectName, ParserArray->ObjectName,