tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg UfsPassThru: ASSERT if params are NULL in SignalCallerEvent 

In function SignalCallerEvent(), 'Private' and 'TransReq' are dereferenced
before NULL checking.

Since the function assumes that both 'Private' and 'TransReq' passed in
are not NULL pointer, this commit will add an ASSERT to make sure the
above assumption is satisfied.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19266 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Hao Wu 2015-12-15 05:43:08 +00:00 committed by hwu1225
parent 8e59d39524
commit 33e2ba78ee
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c
View File

@ -2191,6 +2191,8 @@ SignalCallerEvent (
EDKII_UFS_HOST_CONTROLLER_PROTOCOL *UfsHc; EDKII_UFS_HOST_CONTROLLER_PROTOCOL *UfsHc;
EFI_EVENT CallerEvent; EFI_EVENT CallerEvent;
ASSERT ((Private != NULL) && (TransReq != NULL));
UfsHc = Private->UfsHostController; UfsHc = Private->UfsHostController;
CallerEvent = TransReq->CallerEvent; CallerEvent = TransReq->CallerEvent;
@ -2214,9 +2216,8 @@ SignalCallerEvent (
TransReq->CmdDescHost TransReq->CmdDescHost
); );
} }
if (TransReq != NULL) {
FreePool (TransReq); FreePool (TransReq);
}
gBS->SignalEvent (CallerEvent); gBS->SignalEvent (CallerEvent);
return; return;