tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdePkg/Ftp4: Fix wrong function pointer declaration 

EFI_FTP4_DATA_CALLBACK is a function pointer and defined as follows:

> typedef
> EFI_STATUS
> (EFIAPI *EFI_FTP4_DATA_CALLBACK)(
>  IN EFI_FTP4_PROTOCOL           *This,
>  IN EFI_FTP4_COMMAND_TOKEN      *Token
>  );

And EFI_FTP4_COMMAND_TOKEN structure declared it as:

> EFI_FTP4_DATA_CALLBACK *DataCallback

Which ended up being a pointer to function pointer and clearly wrong.
This patch fixes it by removing the misleading '*' from declaration.
It's also fixed in new UEFI 2.7 spec.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Paulo Alcantara <paulo.alc.cavalcanti@hp.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
This commit is contained in:
Alcantara, Paulo 2017-06-06 08:33:36 +08:00 committed by Fu Siyuan
parent 45ea8a0c45
commit 354a75f9ed
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MdePkg/Include/Protocol/Ftp4.h
View File

@ -204,7 +204,7 @@ struct _EFI_FTP4_COMMAND_TOKEN {
/// DataBufferSize, again. If there is no data remained,
/// DataBufferSize should be set to 0.
///
EFI_FTP4_DATA_CALLBACK *DataCallback;
EFI_FTP4_DATA_CALLBACK DataCallback;
///
/// Pointer to the parameter for DataCallback.
///