From 38ed2ff3dd4edebbdcd1ae7da471464b663a2e21 Mon Sep 17 00:00:00 2001 From: Philippe Mathieu-Daude Date: Wed, 5 Feb 2020 06:49:15 +0800 Subject: [PATCH] BaseTools/Scripts/PatchCheck.py: Detect emails rewritten by Groups.Io Due to strict DMARC / DKIM / SPF rules, Groups.Io sometimes rewrite the author email. See for example commit df851da3ceff5b6bcf5e12616. Add a check to detect these rewrites with PatchCheck.py. Signed-off-by: Philippe Mathieu-Daude Cc: Bob Feng Cc: Liming Gao Reviewed-by: Laszlo Ersek Reviewed-by: Bob Feng --- BaseTools/Scripts/PatchCheck.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 6823cc69bb..73252ef355 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -79,6 +79,10 @@ class EmailAddressCheck: self.error("The email address cannot contain a space: " + mo.group(3)) + if ' via Groups.Io' in name and mo.group(3).endswith('@groups.io'): + self.error("Email rewritten by lists DMARC / DKIM / SPF: " + + email) + class CommitMessageCheck: """Checks the contents of a git commit message."""