Refine code to make it more safely.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>




git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15589 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Eric Dong 2014-06-25 05:44:37 +00:00 committed by ydong10
parent 53db912ea1
commit 393a3169c2
5 changed files with 11 additions and 7 deletions

View File

@ -1,7 +1,7 @@
/** @file /** @file
The implementation for Shell application IfConfig6. The implementation for Shell application IfConfig6.
Copyright (c) 2009 - 2011, Intel Corporation. All rights reserved.<BR> Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
@ -365,6 +365,7 @@ IfConfig6ParseManualAddressList (
UINT8 Prefix; UINT8 Prefix;
UINT8 AddrCnt; UINT8 AddrCnt;
Prefix = 0;
AddrCnt = 0; AddrCnt = 0;
*BufSize = 0; *BufSize = 0;
*Buf = NULL; *Buf = NULL;

View File

@ -143,10 +143,10 @@ Dhcp6GenerateClientId (
// //
// Set the Duid-type, hardware-type, time and copy the hardware address. // Set the Duid-type, hardware-type, time and copy the hardware address.
// //
WriteUnaligned16 ((UINT16 *) (Duid->Duid), HTONS (Dhcp6DuidTypeLlt)); WriteUnaligned16 ((UINT16 *) ((UINT8 *)&Duid + OFFSET_OF (EFI_DHCP6_DUID, Duid)), HTONS (Dhcp6DuidTypeLlt));
WriteUnaligned16 ((UINT16 *) (Duid->Duid + 2), HTONS (NET_IFTYPE_ETHERNET)); WriteUnaligned16 ((UINT16 *) ((UINT8 *)&Duid + OFFSET_OF (EFI_DHCP6_DUID, Duid) + 2), HTONS (NET_IFTYPE_ETHERNET));
WriteUnaligned32 ((UINT32 *) (Duid->Duid + 4), HTONL (Stamp)); WriteUnaligned32 ((UINT32 *) ((UINT8 *)&Duid + OFFSET_OF (EFI_DHCP6_DUID, Duid) + 4), HTONL (Stamp));
CopyMem (Duid->Duid + 8, &Mode->CurrentAddress, Mode->HwAddressSize); CopyMem (Duid->Duid + 8, &Mode->CurrentAddress, Mode->HwAddressSize);
} }

View File

@ -1,7 +1,7 @@
/** @file /** @file
Helper functions for configuring or obtaining the parameters relating to IP6. Helper functions for configuring or obtaining the parameters relating to IP6.
Copyright (c) 2010 - 2013, Intel Corporation. All rights reserved.<BR> Copyright (c) 2010 - 2014, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
@ -600,6 +600,7 @@ Ip6ParseAddressListFromString (
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
} }
ZeroMem (&AddressInfo, sizeof (EFI_IP6_ADDRESS_INFO));
LocalString = (CHAR16 *) AllocateCopyPool (StrSize (String), String); LocalString = (CHAR16 *) AllocateCopyPool (StrSize (String), String);
if (LocalString == NULL) { if (LocalString == NULL) {
return EFI_OUT_OF_RESOURCES; return EFI_OUT_OF_RESOURCES;

View File

@ -1,7 +1,7 @@
/** @file /** @file
The Common operations used by IKE Exchange Process. The Common operations used by IKE Exchange Process.
Copyright (c) 2010 - 2011, Intel Corporation. All rights reserved.<BR> Copyright (c) 2010 - 2014, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
@ -928,6 +928,7 @@ Ikev2ChildSaSilentDelete (
FreePool (Selector); FreePool (Selector);
Selector = AllocateZeroPool (SelectorSize); Selector = AllocateZeroPool (SelectorSize);
ASSERT (Selector != NULL);
Status = EfiIpSecConfigGetNextSelector ( Status = EfiIpSecConfigGetNextSelector (
&Private->IpSecConfig, &Private->IpSecConfig,
IPsecConfigDataTypeSad, IPsecConfigDataTypeSad,

View File

@ -600,6 +600,7 @@ EfiPxeBcDiscover (
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
goto ON_EXIT; goto ON_EXIT;
} }
ASSERT (NewCreatedInfo != NULL);
Info = NewCreatedInfo; Info = NewCreatedInfo;
} else { } else {
// //