tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BaseTools/GenVtf: Fix potential memory leak 

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Hao Wu 2016-10-11 15:18:32 +08:00
parent 77e4cf5f11
commit 399caf2d14
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
BaseTools/Source/C/GenVtf/GenVtf.c
View File

@ -1232,11 +1232,13 @@ Returns:
Vtf1TotalSize += (UINT32) (FileSize + NumAdjustByte); Vtf1TotalSize += (UINT32) (FileSize + NumAdjustByte);
Status = UpdateVtfBuffer (CompStartAddress, Buffer, FileSize, FIRST_VTF); Status = UpdateVtfBuffer (CompStartAddress, Buffer, FileSize, FIRST_VTF);
} else { } else {
free (Buffer);
Error (NULL, 0, 2000,"Invalid Parameter", "There's component in second VTF so second BaseAddress and Size must be specified!"); Error (NULL, 0, 2000,"Invalid Parameter", "There's component in second VTF so second BaseAddress and Size must be specified!");
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
} }
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
free (Buffer);
return EFI_ABORTED; return EFI_ABORTED;
} }
@ -1248,6 +1250,7 @@ Returns:
CompFitPtr->CompAddress = CompStartAddress | IPF_CACHE_BIT; CompFitPtr->CompAddress = CompStartAddress | IPF_CACHE_BIT;
if ((FileSize % 16) != 0) { if ((FileSize % 16) != 0) {
free (Buffer);
Error (NULL, 0, 2000, "Invalid parameter", "Binary FileSize must be a multiple of 16."); Error (NULL, 0, 2000, "Invalid parameter", "Binary FileSize must be a multiple of 16.");
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
} }
@ -1389,6 +1392,7 @@ Returns:
PalFitPtr->CompAddress = PalStartAddress | IPF_CACHE_BIT; PalFitPtr->CompAddress = PalStartAddress | IPF_CACHE_BIT;
//assert ((FileSize % 16) == 0); //assert ((FileSize % 16) == 0);
if ((FileSize % 16) != 0) { if ((FileSize % 16) != 0) {
free (Buffer);
Error (NULL, 0, 2000, "Invalid parameter", "Binary FileSize must be a multiple of 16."); Error (NULL, 0, 2000, "Invalid parameter", "Binary FileSize must be a multiple of 16.");
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
} }