tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-27 07:34:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

DxeCore is designed to trust input data, so add comments to reminder caller to do check to follow PI specification when necessary.

Browse Source 
Since LBA_CACHE is DxeCore implementation specific, DxeCore will check it here.

Signed-off by: jiewen yao <jiewen.yao@intel.com>
Reviewed by: liming gao <liming.gao@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15136 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
jyao1 2014-01-17 03:42:09 +00:00 committed by jyao1
parent 4dd8c7af19
commit 3a1966c4e2
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
View File

@ -4,7 +4,7 @@
It consumes FV HOBs and creates read-only Firmare Volume Block protocol It consumes FV HOBs and creates read-only Firmare Volume Block protocol
instances for each of them. instances for each of them.
Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -524,9 +524,14 @@ ProduceFVBProtocolOnBuffer (
PtrBlockMapEntry++) { PtrBlockMapEntry++) {
FvbDev->NumBlocks += PtrBlockMapEntry->NumBlocks; FvbDev->NumBlocks += PtrBlockMapEntry->NumBlocks;
} }
// //
// Second, allocate the cache // Second, allocate the cache
// //
if (FvbDev->NumBlocks >= (MAX_ADDRESS / sizeof (LBA_CACHE))) {
CoreFreePool (FvbDev);
return EFI_OUT_OF_RESOURCES;
}
FvbDev->LbaCache = AllocatePool (FvbDev->NumBlocks * sizeof (LBA_CACHE)); FvbDev->LbaCache = AllocatePool (FvbDev->NumBlocks * sizeof (LBA_CACHE));
if (FvbDev->LbaCache == NULL) { if (FvbDev->LbaCache == NULL) {
CoreFreePool (FvbDev); CoreFreePool (FvbDev);
@ -641,6 +646,10 @@ FwVolBlockDriverInit (
particular, it can be called by BDS to process a single firmware particular, it can be called by BDS to process a single firmware
volume found in a capsule. volume found in a capsule.
Caution: The caller need validate the input firmware volume to follow
PI specification.
DxeCore will trust the input data and process firmware volume directly.
@param FvHeader pointer to a firmware volume header @param FvHeader pointer to a firmware volume header
@param Size the size of the buffer pointed to by FvHeader @param Size the size of the buffer pointed to by FvHeader
@param FVProtocolHandle the handle on which a firmware volume protocol @param FVProtocolHandle the handle on which a firmware volume protocol