From 3a7a6761143a4840faea0bd84daada3ac0f1bd22 Mon Sep 17 00:00:00 2001 From: Bob Feng Date: Wed, 23 Sep 2020 20:36:58 +0800 Subject: [PATCH] BaseTools: Remove CanSkip calling for incremental build REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2978 If a module add a new PCD, the pcd token number will be reassigned. The new Pcd token number should be updated to all module's autogen files. CanSkip can only detect a single module's change but not others. CanSkip block the pcd token number update in incremental build, so this patch is going to remove this call. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Reviewed-by: Yuwei Chen --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py index dc8b1fe3d1..eebf6e87f5 100755 --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py @@ -1822,9 +1822,6 @@ class ModuleAutoGen(AutoGen): for LibraryAutoGen in self.LibraryAutoGenList: LibraryAutoGen.CreateCodeFile() - # CanSkip uses timestamps to determine build skipping - if self.CanSkip(): - return self.LibraryAutoGenList AutoGenList = [] IgoredAutoGenList = []