MdeModulePkg/Core: Decorate phase-transition functions with NORETURN.

This patch adds the NORETURN attribute to functions that transfer to
other phases, along with an UNREACHABLE() call at the end to avoid
false warnings.
DxeIpl has been excluded as its main function returns a status.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>

MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c

@@ -235,6 +235,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_LOAD_FIXED_ADDRESS_CONFIGURATION_TABLE    gLoa
 
 **/
 VOID
+NORETURN
 EFIAPI
 DxeMain (
   IN  VOID *HobStart
@@ -524,6 +525,8 @@ DxeMain (
   //
   ASSERT (FALSE);
   CpuDeadLoop ();
+
+  UNREACHABLE ();
 }
 
 

MdeModulePkg/Core/Pei/PeiMain.h

@@ -315,6 +315,7 @@ typedef struct {
 
 **/
 VOID
+NORETURN
 EFIAPI
 PeiCore (
   IN CONST EFI_SEC_PEI_HAND_OFF        *SecCoreData,

MdeModulePkg/Core/Pei/PeiMain/PeiMain.c

@@ -136,6 +136,7 @@ ShadowPeiCore (
 
 **/
 VOID
+NORETURN
 EFIAPI
 PeiCore (
   IN CONST EFI_SEC_PEI_HAND_OFF        *SecCoreDataPtr,
@@ -275,6 +276,8 @@ PeiCore (
       //
       ASSERT (FALSE);
       CpuDeadLoop();
+
+      UNREACHABLE ();
     }
 
     //
@@ -468,4 +471,6 @@ PeiCore (
   //
   ASSERT_EFI_ERROR (Status);
   CpuDeadLoop();
+
+  UNREACHABLE ();
 }