From 3d131d1a207103cf0f5a849c6972a139156d9bd2 Mon Sep 17 00:00:00 2001 From: jljusten Date: Wed, 13 Oct 2010 07:07:16 +0000 Subject: [PATCH] OVMF BDS: Don't call BdsLibSaveMemoryTypeInformation This call can cause a reset, and is most critical for ACPI S3/S4 resume situations. OVMF does not support S3/S4. OVMF does not have true non-volatile variable support, so this call could cause a continuous reset situation in certain scenarios. (The BdsLibSaveMemoryTypeInformation may set an non-volatile variable, and then reset with the assumption that the variable will still exist during the next boot.) Additionally, some version of QEMU appear to hang when the port 64 reset is initiated. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10927 6f19259b-4bc3-4df7-8a09-765794883524 --- OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c index cce0dde4ec..b0d045df9b 100644 --- a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c @@ -110,7 +110,6 @@ Returns: --*/ { DEBUG ((EFI_D_INFO, "PlatformBdsInit\n")); - BdsLibSaveMemoryTypeInformation (); InstallDevicePathCallback (); LoadVideoRom (); } @@ -884,7 +883,7 @@ PlatformBdsRestoreNvVarsFromHardDisk ( VisitingFileSystemInstance, NULL ); - + }