tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdePkg: Fix broken coding style in Acpi64.h 

Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)

Fix a coding style issue raised by EccCheck. This issue (error code
7008) has been fixed by moving a nested union out of its structure.

Also add Acpi64.h to the "IgnoreFiles" list to stop the CI flagging
naming errors present prior to ACPI 64.

Signed-off-by: Chris Jones <christopher.jones@arm.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
This commit is contained in:
Chris Jones 2021-07-29 11:10:24 +01:00 committed by mergify[bot]
parent 605c4a1ff2
commit 3d359ff905
2 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
MdePkg/Include/IndustryStandard/Acpi64.h
View File

@ -787,6 +787,14 @@ typedef struct {
UINT8 Reserved[12];
} EFI_ACPI_6_4_DEVICE_HANDLE_PCI;
///
/// Device Handle
///
typedef union {
EFI_ACPI_6_4_DEVICE_HANDLE_ACPI Acpi;
EFI_ACPI_6_4_DEVICE_HANDLE_PCI Pci;
} EFI_ACPI_6_4_DEVICE_HANDLE;
///
/// Generic Initiator Affinity Structure
///
@ -796,12 +804,7 @@ typedef struct {
UINT8 Reserved1;
UINT8 DeviceHandleType;
UINT32 ProximityDomain;
union {
EFI_ACPI_6_4_DEVICE_HANDLE_ACPI Acpi;
EFI_ACPI_6_4_DEVICE_HANDLE_PCI Pci;
} DeviceHandle;
EFI_ACPI_6_4_DEVICE_HANDLE DeviceHandle;
UINT32 Flags;
UINT8 Reserved2[4];
} EFI_ACPI_6_4_GENERIC_INITIATOR_AFFINITY_STRUCTURE;

2
MdePkg/MdePkg.ci.yaml
View File

@ -3,6 +3,7 @@
#
# Copyright (c) Microsoft Corporation
# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
@ -19,6 +20,7 @@
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
"Include/IndustryStandard/Acpi64.h"
]
},
## options defined ci/Plugin/CompilerPlugin