From 3d37d5c9f4bfbc1cc4432a0ad68dc3b4d50904fd Mon Sep 17 00:00:00 2001 From: ocbuild Date: Thu, 13 Jan 2022 14:08:36 +0300 Subject: [PATCH] Svace: Fixed INTEGER_OVERFLOW warnings. --- MdeModulePkg/Universal/PCD/Dxe/Service.c | 3 ++- MdeModulePkg/Universal/PCD/Pei/Service.c | 1 + UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/PCD/Dxe/Service.c b/MdeModulePkg/Universal/PCD/Dxe/Service.c index badeec8c97..0e5831e54c 100644 --- a/MdeModulePkg/Universal/PCD/Dxe/Service.c +++ b/MdeModulePkg/Universal/PCD/Dxe/Service.c @@ -1028,6 +1028,7 @@ InvokeCallbackOnSet ( LIST_ENTRY *ListHead; LIST_ENTRY *ListNode; + ASSERT (TokenNumber > 0); // // TokenNumber Zero is reserved as PCD_INVALID_TOKEN_NUMBER. // We have to decrement TokenNumber by 1 to make it usable @@ -1112,6 +1113,7 @@ SetWorker ( UINTN MaxSize; UINTN TmpTokenNumber; + ASSERT (TokenNumber > 0); // // TokenNumber Zero is reserved as PCD_INVALID_TOKEN_NUMBER. // We have to decrement TokenNumber by 1 to make it usable @@ -1899,4 +1901,3 @@ VariableLockCallBack ( VariableLockDynamicHiiPcd (FALSE, VariableLock); } } - diff --git a/MdeModulePkg/Universal/PCD/Pei/Service.c b/MdeModulePkg/Universal/PCD/Pei/Service.c index 5b037353ad..7671750389 100644 --- a/MdeModulePkg/Universal/PCD/Pei/Service.c +++ b/MdeModulePkg/Universal/PCD/Pei/Service.c @@ -857,6 +857,7 @@ GetWorker ( UINT8 *VaraiableDefaultBuffer; UINTN VpdBaseAddress; + ASSERT (TokenNumber > 0); // // TokenNumber Zero is reserved as PCD_INVALID_TOKEN_NUMBER. // We have to decrement TokenNumber by 1 to make it usable diff --git a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c index ceab7a065f..77d3c882c4 100644 --- a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c +++ b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c @@ -969,7 +969,7 @@ MtrrLibSetMemoryType ( UINT64 LengthRight; UINTN StartIndex; UINTN EndIndex; - UINTN DeltaCount; + INTN DeltaCount; LengthRight = 0; LengthLeft = 0;