From 3d9d66ad760b67bfdfb5b4b8e9b34f6af6c45935 Mon Sep 17 00:00:00 2001 From: Shenglei Zhang Date: Tue, 7 Jul 2020 10:44:55 +0800 Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836 Current PatchCheck.py checks each line to ensure line's length is not larger than 76. But there's a case that length of user's name is much longer than that number. So enhance the script to handle this case. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang Reviewed-by: Yuwei Chen Reviewed-by: Liming Gao --- BaseTools/Scripts/PatchCheck.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4..7db0775d14 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -268,7 +268,14 @@ class CommitMessageCheck: for i in range(2, count): if (len(lines[i]) >= 76 and len(lines[i].split()) > 1 and - not lines[i].startswith('git-svn-id:')): + not lines[i].startswith('git-svn-id:') and + not lines[i].startswith('Reviewed-by') and + not lines[i].startswith('Acked-by:') and + not lines[i].startswith('Tested-by:') and + not lines[i].startswith('Reported-by:') and + not lines[i].startswith('Suggested-by:') and + not lines[i].startswith('Signed-off-by:') and + not lines[i].startswith('Cc:')): # # Print a warning if body line is longer than 75 characters #