tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-28 08:04:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

MdePkg/PciExpress21.h: Fix typo in PCI_REG_PCIE_SLOT_CONTROL

Browse Source 
PCI_REG_PCIE_SLOT_CONTROL contains a typo. It is defined as:
typedef union {
  struct {
    UINT32 AttentionButtonPressed : 1;
    UINT32 ...
    ...
  } Bits;
  UINT16   Uint16;
} PCI_REG_PCIE_SLOT_CONTROL;

The bit field data type should be UINT16 instead of UINT32,
results sizeof (PCI_REG_PCIE_SLOT_CONTROL) equals to 4 instead of 2.

Because this structure is used in PCI_CAPABILITY_PCIEXP as below:
typedef struct {
  ...
  PCI_REG_PCIE_SLOT_CONTROL       SlotControl;
  PCI_REG_PCIE_SLOT_STATUS        SlotStatus;
} PCI_CAPABILITY_PCIEXP;

It cause the OFFSET_OF (PCI_CAPABILITY_PCIEXP, SlotStatus) equal
to a wrong value.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Ruiyu Ni 2017-10-26 16:06:56 +08:00
parent cb68247d5c
commit 400a59737f
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
MdePkg/Include/IndustryStandard/PciExpress21.h
View File

@ -182,18 +182,18 @@ typedef union {
typedef union { typedef union {
struct { struct {
UINT32 AttentionButtonPressed : 1; UINT16 AttentionButtonPressed : 1;
UINT32 PowerFaultDetected : 1; UINT16 PowerFaultDetected : 1;
UINT32 MrlSensorChanged : 1; UINT16 MrlSensorChanged : 1;
UINT32 PresenceDetectChanged : 1; UINT16 PresenceDetectChanged : 1;
UINT32 CommandCompletedInterrupt : 1; UINT16 CommandCompletedInterrupt : 1;
UINT32 HotPlugInterrupt : 1; UINT16 HotPlugInterrupt : 1;
UINT32 AttentionIndicator : 2; UINT16 AttentionIndicator : 2;
UINT32 PowerIndicator : 2; UINT16 PowerIndicator : 2;
UINT32 PowerController : 1; UINT16 PowerController : 1;
UINT32 ElectromechanicalInterlock : 1; UINT16 ElectromechanicalInterlock : 1;
UINT32 DataLinkLayerStateChanged : 1; UINT16 DataLinkLayerStateChanged : 1;
UINT32 Reserved : 3; UINT16 Reserved : 3;
} Bits; } Bits;
UINT16 Uint16; UINT16 Uint16;
} PCI_REG_PCIE_SLOT_CONTROL; } PCI_REG_PCIE_SLOT_CONTROL;