tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

IntelFsp2Pkg: Remove CarBase and CarSize from FSP_GLOBAL_DATA 

CarBase and CarSize in Fsp Global data structure are no longer needed as
Boot loader doesn't pass them to FSP even in case that BL chooses to skip calling
the FspTempRamInit API. In case of FspTempramInit is called, we can use the PCDs
to identify the CarBase and Size. Hence we remove the relevant code.

Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
This commit is contained in:
Satya Yarlagadda 2016-07-20 14:49:15 +08:00 committed by Jiewen Yao
parent c243b74432
commit 40bc750914
4 changed files with 1 additions and 67 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
IntelFsp2Pkg/FspSecCore/SecFsp.c
View File

@ -76,7 +76,7 @@ SecGetPlatformData (
//
// Pointer to the size field
//
TopOfCar = FspPlatformData->CarBase + FspPlatformData->CarSize;
TopOfCar = PcdGet32(PcdTemporaryRamBase) + PcdGet32(PcdTemporaryRamSize);
StackPtr = (UINT32 *)(TopOfCar - sizeof (UINT32));
if (*(StackPtr - 1) == FSP_MCUD_SIGNATURE) {
@ -140,8 +140,6 @@ FspGlobalDataInit (
PeiFspData->CoreStack = BootLoaderStack;
PeiFspData->PerfIdx = 2;
PeiFspData->PerfSig = FSP_PERFORMANCE_DATA_SIGNATURE;
PeiFspData->PlatformData.CarBase = AsmReadMsr32 (0x200) & ~(0x6);
PeiFspData->PlatformData.CarSize = ~(AsmReadMsr32(0x201) & ~(0x800)) + 1;
SetFspMeasurePoint (FSP_PERF_ID_API_FSP_MEMORY_INIT_ENTRY);

2
IntelFsp2Pkg/Include/FspGlobalData.h
View File

@ -34,8 +34,6 @@ typedef struct {
UINT32 MicrocodeRegionSize;
UINT32 CodeRegionBase;
UINT32 CodeRegionSize;
UINT32 CarBase;
UINT32 CarSize;
} FSP_PLAT_DATA;
#define FSP_GLOBAL_DATA_SIGNATURE SIGNATURE_32 ('F', 'S', 'P', 'D')

20
IntelFsp2Pkg/Include/Library/FspCommonLib.h
View File

@ -289,26 +289,6 @@ SetPhaseStatusCode (
UINT32 StatusCode
);
/**
This function gets FSP CAR base.
**/
UINT32
EFIAPI
GetFspCarBase (
VOID
);
/**
This function gets FSP CAR size.
**/
UINT32
EFIAPI
GetFspCarSize (
VOID
);
/**
This function updates the return status of the FSP API with requested reset type and returns to Boot Loader.

42
IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
View File

@ -504,48 +504,6 @@ SetPhaseStatusCode (
FspData->StatusCode = StatusCode;
}
/**
This function gets FSP CAR base.
**/
UINT32
EFIAPI
GetFspCarBase (
VOID
)
{
FSP_GLOBAL_DATA *FspData;
UINT32 CarBase;
FspData = GetFspGlobalDataPointer ();
CarBase = FspData->PlatformData.CarBase;
if (CarBase == 0) {
CarBase = PcdGet32(PcdTemporaryRamBase);
}
return CarBase;
}
/**
This function gets FSP CAR size.
**/
UINT32
EFIAPI
GetFspCarSize (
VOID
)
{
FSP_GLOBAL_DATA *FspData;
UINT32 CarSize;
FspData = GetFspGlobalDataPointer ();
CarSize = FspData->PlatformData.CarSize;
if (FspData->PlatformData.CarBase == 0) {
CarSize = PcdGet32(PcdTemporaryRamSize);
}
return CarSize;
}
/**
This function updates the return status of the FSP API with requested reset type and returns to Boot Loader.