From 4266d751365033ab7b5284d32368a46a0cccc4b8 Mon Sep 17 00:00:00 2001 From: Mikhail Krichanov Date: Thu, 11 Jul 2024 11:45:07 +0300 Subject: [PATCH] SysCall/ARM: Added TODO comments. --- MdeModulePkg/Core/Dxe/SysCall/ARM/InitializeMsr.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/MdeModulePkg/Core/Dxe/SysCall/ARM/InitializeMsr.c b/MdeModulePkg/Core/Dxe/SysCall/ARM/InitializeMsr.c index eb6d555734..d08066df46 100644 --- a/MdeModulePkg/Core/Dxe/SysCall/ARM/InitializeMsr.c +++ b/MdeModulePkg/Core/Dxe/SysCall/ARM/InitializeMsr.c @@ -96,12 +96,19 @@ InitializeMsr ( IN UINTN NumberOfEntries ) { + // + // TODO: EFI_CONFIGURATION_TABLE, HOB_DATA, Uart are accessible to User. + // Fix PageTable initialization. + // if (ArmHasPan ()) { // // Enable Privileged Access Never feature. // ArmSetPan (); } else { + // + // TODO: Refactoring. + // DEBUG ((DEBUG_ERROR, "Core: Failed to initialize MSRs for Ring3.\n")); // ASSERT (FALSE); } @@ -109,6 +116,9 @@ InitializeMsr ( InitializeSysCallHandler (SysCallBootService); } +// +// TODO: Refactoring. +// VOID EFIAPI DisableSMAP (