tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-10-31 19:23:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/VarCheckHii: Update data type for variable "ArrayIndex"

Browse Source 
In some case the ArrayIndex with UINT16 may be not large enough to
hold the multiplication result of HiiQuestion->VarOffset * 8;
So this patch update the data type to fix this potential issue.

Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
This commit is contained in:
Bi, Dandan 2018-01-09 15:24:44 +08:00 committed by Star Zeng
parent 2117989c26
commit 427b2f41a6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGen.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
Var Check Hii bin generation. Var Check Hii bin generation.
Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR> Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -515,7 +515,7 @@ MergeHiiQuestion (
UINT8 *Ptr; UINT8 *Ptr;
UINT8 *Ptr1; UINT8 *Ptr1;
UINT8 *Ptr2; UINT8 *Ptr2;
UINT16 ArrayIndex; UINTN ArrayIndex;
// //
// Hii Question from Hii Database has high priority. // Hii Question from Hii Database has high priority.
@ -1064,7 +1064,7 @@ ParseHiiQuestion (
) )
{ {
VAR_CHECK_HII_QUESTION_HEADER *HiiQuestion; VAR_CHECK_HII_QUESTION_HEADER *HiiQuestion;
UINT16 ArrayIndex; UINTN ArrayIndex;
// //
// Currently only OneOf, CheckBox and Numeric can be stored in bit field. // Currently only OneOf, CheckBox and Numeric can be stored in bit field.