From 4423f0bc613b5451feaa546c3f330ad625d65638 Mon Sep 17 00:00:00 2001 From: Yonghong Zhu Date: Wed, 5 Sep 2018 11:26:15 +0800 Subject: [PATCH] BaseTools: Fix the RaiseError variable issue caused by 855698fb69f The bug is that it cause the RaiseError always be set to TRUE even we call the function with FALSE parameter. Cc: Hess Chen Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu Reviewed-by: Hess Chen --- BaseTools/Source/Python/Common/EdkLogger.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/Common/EdkLogger.py b/BaseTools/Source/Python/Common/EdkLogger.py index 80697bf09b..af7707482c 100644 --- a/BaseTools/Source/Python/Common/EdkLogger.py +++ b/BaseTools/Source/Python/Common/EdkLogger.py @@ -198,8 +198,8 @@ def error(ToolName, ErrorCode, Message=None, File=None, Line=None, ExtraData=Non LogText = _ErrorMessageTemplateWithoutFile % TemplateDict _ErrorLogger.log(ERROR, LogText) - RaiseError = IsRaiseError - if RaiseError: + + if RaiseError and IsRaiseError: raise FatalError(ErrorCode) # Log information which should be always put out