tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-25 22:54:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

DynamicTablesPkg: AmlLib CONST cleanup

Browse Source 
Several input strings to AmlLib APIs are treated
as CONST but were missing the CONST keyword,
requiring their callers to create unnecessary r/w
copies of r/o input strings. This change properly
marks these input strings as CONST.

Signed-off-by: Jeshua Smith <jeshuas@nvidia.com>
Reviewed-by: Jeff Brasen <jbrasen@nvidia.com>
This commit is contained in:
Jeshua Smith 2024-05-03 14:25:37 -07:00 committed by mergify[bot]
parent 8c09d862bf
commit 469d09d6b2
4 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
View File

@ -339,7 +339,7 @@ EFI_STATUS
EFIAPI EFIAPI
AmlFindNode ( AmlFindNode (
IN AML_NODE_HANDLE ReferenceNode, IN AML_NODE_HANDLE ReferenceNode,
IN CHAR8 *AslPath, IN CONST CHAR8 *AslPath,
OUT AML_NODE_HANDLE *OutNode OUT AML_NODE_HANDLE *OutNode
); );
@ -374,7 +374,7 @@ EFI_STATUS
EFIAPI EFIAPI
AmlDeviceOpUpdateName ( AmlDeviceOpUpdateName (
IN AML_OBJECT_NODE_HANDLE DeviceOpNode, IN AML_OBJECT_NODE_HANDLE DeviceOpNode,
IN CHAR8 *NewNameString IN CONST CHAR8 *NewNameString
); );
/** Update an integer value defined by a NameOp object node. /** Update an integer value defined by a NameOp object node.
@ -1090,7 +1090,7 @@ EFI_STATUS
EFIAPI EFIAPI
AmlCodeGenNameString ( AmlCodeGenNameString (
IN CONST CHAR8 *NameString, IN CONST CHAR8 *NameString,
IN CHAR8 *String, IN CONST CHAR8 *String,
IN AML_NODE_HANDLE ParentNode OPTIONAL, IN AML_NODE_HANDLE ParentNode OPTIONAL,
OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL
); );
@ -1613,7 +1613,7 @@ AmlAddLpiState (
IN UINT64 Integer OPTIONAL, IN UINT64 Integer OPTIONAL,
IN EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE *ResidencyCounterRegister OPTIONAL, IN EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE *ResidencyCounterRegister OPTIONAL,
IN EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE *UsageCounterRegister OPTIONAL, IN EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE *UsageCounterRegister OPTIONAL,
IN CHAR8 *StateName OPTIONAL, IN CONST CHAR8 *StateName OPTIONAL,
IN AML_OBJECT_NODE_HANDLE LpiNode IN AML_OBJECT_NODE_HANDLE LpiNode
); );
@ -1668,7 +1668,7 @@ AmlAddDeviceDataDescriptorPackage (
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI
AmlAddNameIntegerPackage ( AmlAddNameIntegerPackage (
IN CHAR8 *Name, IN CONST CHAR8 *Name,
IN UINT64 Value, IN UINT64 Value,
IN AML_OBJECT_NODE_HANDLE PackageNode IN AML_OBJECT_NODE_HANDLE PackageNode
); );
@ -1739,7 +1739,7 @@ AmlCreateCpcNode (
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI
AmlAddNameStringToNamedPackage ( AmlAddNameStringToNamedPackage (
IN CHAR8 *NameString, IN CONST CHAR8 *NameString,
IN AML_OBJECT_NODE_HANDLE NamedNode IN AML_OBJECT_NODE_HANDLE NamedNode
); );

2
DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApi.c
View File

@ -40,7 +40,7 @@ EFI_STATUS
EFIAPI EFIAPI
AmlDeviceOpUpdateName ( AmlDeviceOpUpdateName (
IN AML_OBJECT_NODE_HANDLE DeviceOpNode, IN AML_OBJECT_NODE_HANDLE DeviceOpNode,
IN CHAR8 *NewNameString IN CONST CHAR8 *NewNameString
) )
{ {
EFI_STATUS Status; EFI_STATUS Status;

10
DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
View File

@ -139,7 +139,7 @@ STATIC
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI
AmlCodeGenString ( AmlCodeGenString (
IN CHAR8 *String, IN CONST CHAR8 *String,
OUT AML_OBJECT_NODE **NewObjectNode OUT AML_OBJECT_NODE **NewObjectNode
) )
{ {
@ -664,7 +664,7 @@ EFI_STATUS
EFIAPI EFIAPI
AmlCodeGenNameString ( AmlCodeGenNameString (
IN CONST CHAR8 *NameString, IN CONST CHAR8 *NameString,
IN CHAR8 *String, IN CONST CHAR8 *String,
IN AML_NODE_HEADER *ParentNode OPTIONAL, IN AML_NODE_HEADER *ParentNode OPTIONAL,
OUT AML_OBJECT_NODE **NewObjectNode OPTIONAL OUT AML_OBJECT_NODE **NewObjectNode OPTIONAL
) )
@ -2615,7 +2615,7 @@ AmlAddLpiState (
IN UINT64 Integer OPTIONAL, IN UINT64 Integer OPTIONAL,
IN EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE *ResidencyCounterRegister OPTIONAL, IN EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE *ResidencyCounterRegister OPTIONAL,
IN EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE *UsageCounterRegister OPTIONAL, IN EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE *UsageCounterRegister OPTIONAL,
IN CHAR8 *StateName OPTIONAL, IN CONST CHAR8 *StateName OPTIONAL,
IN AML_OBJECT_NODE_HANDLE LpiNode IN AML_OBJECT_NODE_HANDLE LpiNode
) )
{ {
@ -3204,7 +3204,7 @@ error_handler:
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI
AmlAddNameIntegerPackage ( AmlAddNameIntegerPackage (
IN CHAR8 *Name, IN CONST CHAR8 *Name,
IN UINT64 Value, IN UINT64 Value,
IN AML_OBJECT_NODE_HANDLE PackageNode IN AML_OBJECT_NODE_HANDLE PackageNode
) )
@ -3800,7 +3800,7 @@ error_handler:
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI
AmlAddNameStringToNamedPackage ( AmlAddNameStringToNamedPackage (
IN CHAR8 *NameString, IN CONST CHAR8 *NameString,
IN AML_OBJECT_NODE_HANDLE NamedNode IN AML_OBJECT_NODE_HANDLE NamedNode
) )
{ {

4
DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
View File

@ -1234,7 +1234,7 @@ EFI_STATUS
EFIAPI EFIAPI
AmlBuildAbsoluteAmlPath ( AmlBuildAbsoluteAmlPath (
IN AML_NODE_HEADER *ReferenceNode, IN AML_NODE_HEADER *ReferenceNode,
IN CHAR8 *AslPath, IN CONST CHAR8 *AslPath,
IN OUT AML_STREAM *RawAmlAbsSearchPathBStream IN OUT AML_STREAM *RawAmlAbsSearchPathBStream
) )
{ {
@ -1373,7 +1373,7 @@ EFI_STATUS
EFIAPI EFIAPI
AmlFindNode ( AmlFindNode (
IN AML_NODE_HEADER *ReferenceNode, IN AML_NODE_HEADER *ReferenceNode,
IN CHAR8 *AslPath, IN CONST CHAR8 *AslPath,
OUT AML_NODE_HEADER **OutNode OUT AML_NODE_HEADER **OutNode
) )
{ {