tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/Core/Dxe: Remove extra connects for UEFI Applications 

https://bugzilla.tianocore.org/show_bug.cgi?id=765

The UEFI Specification Boot Services chapter, StartImage() service,
EFF 1.10 Extension requires extra calls to ConnectController()
if a UEFI Driver produces handles. The DXE Core is performing these
extra calls to ConnectController() without evaluating the ImageType.

A filter is added to not make extra calls to ConnectController()
if the ImageType is EFI_IMAGE_SUBSYSTEM_EFI_APPLICATION.

Without this filter, extra calls to ConnectController() may be
performed by UEFI Applications or a UEFI Shell Applications that
also call ConnectController().

Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
This commit is contained in:
Michael D Kinney 2017-11-06 16:57:36 -08:00
parent ffc1fffd65
commit 471048388c
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
MdeModulePkg/Core/Dxe/Image/Image.c
View File

@ -1703,9 +1703,17 @@ CoreStartImage (
mCurrentImage = LastImage;
//
// Go connect any handles that were created or modified while the image executed.
// UEFI Specification - StartImage() - EFI 1.10 Extension
// To maintain compatibility with UEFI drivers that are written to the EFI
// 1.02 Specification, StartImage() must monitor the handle database before
// and after each image is started. If any handles are created or modified
// when an image is started, then EFI_BOOT_SERVICES.ConnectController() must
// be called with the Recursive parameter set to TRUE for each of the newly
// created or modified handles before StartImage() returns.
//
CoreConnectHandlesByKey (HandleDatabaseKey);
if (Image->Type != EFI_IMAGE_SUBSYSTEM_EFI_APPLICATION) {
CoreConnectHandlesByKey (HandleDatabaseKey);
}
//
// Handle the image's returned ExitData