From 47affb48e9baf3966842919acc0c419129c65392 Mon Sep 17 00:00:00 2001 From: Hao Wu Date: Tue, 11 Oct 2016 11:08:41 +0800 Subject: [PATCH] BaseTools/EfiRom: Add checks for user/file inputs Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu Reviewed-by: Liming Gao --- BaseTools/Source/C/EfiRom/EfiRom.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/C/EfiRom/EfiRom.c b/BaseTools/Source/C/EfiRom/EfiRom.c index 622a12f04d..d95864abc9 100644 --- a/BaseTools/Source/C/EfiRom/EfiRom.c +++ b/BaseTools/Source/C/EfiRom/EfiRom.c @@ -979,7 +979,12 @@ Returns: Error (NULL, 0, 2000, "Invalid parameter", "Missing output file name with %s option!", Argv[0]); return STATUS_ERROR; } - strcpy (Options->OutFileName, Argv[1]); + if (strlen (Argv[1]) > MAX_PATH - 1) { + Error (NULL, 0, 2000, "Invalid parameter", "Output file name %s is too long!", Argv[1]); + return STATUS_ERROR; + } + strncpy (Options->OutFileName, Argv[1], MAX_PATH - 1); + Options->OutFileName[MAX_PATH - 1] = 0; Argv++; Argc--;