tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-25 22:54:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

1. Fixed incorrect ASSERT conditions in wrapper functions.

Browse Source 
2. Removed unnecessary SUB instructions in CompareMem.asm

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@318 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
bxing 2006-05-30 05:42:49 +00:00
parent 9d6d8b24f3
commit 49c80af423
20 changed files with 36 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
MdePkg/Library/BaseMemoryLib/SetMem16Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem16 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/BaseMemoryLib/SetMem32Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem32 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/BaseMemoryLib/SetMem64Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem64 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

1
MdePkg/Library/BaseMemoryLibMmx/Ia32/CompareMem.asm
View File

@ -39,7 +39,6 @@ InternalMemCompareMem PROC USES esi edi
movzx eax, byte ptr [esi - 1] movzx eax, byte ptr [esi - 1]
movzx edx, byte ptr [edi - 1] movzx edx, byte ptr [edi - 1]
sub eax, edx sub eax, edx
sub eax, edx
ret ret
InternalMemCompareMem ENDP InternalMemCompareMem ENDP

4
MdePkg/Library/BaseMemoryLibMmx/SetMem16Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem16 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/BaseMemoryLibMmx/SetMem32Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem32 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/BaseMemoryLibMmx/SetMem64Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem64 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/BaseMemoryLibRepStr/SetMem16Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem16 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/BaseMemoryLibRepStr/SetMem32Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem32 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/BaseMemoryLibRepStr/SetMem64Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem64 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

1
MdePkg/Library/BaseMemoryLibSse2/Ia32/CompareMem.asm
View File

@ -39,7 +39,6 @@ InternalMemCompareMem PROC USES esi edi
movzx eax, byte ptr [esi - 1] movzx eax, byte ptr [esi - 1]
movzx edx, byte ptr [edi - 1] movzx edx, byte ptr [edi - 1]
sub eax, edx sub eax, edx
sub eax, edx
ret ret
InternalMemCompareMem ENDP InternalMemCompareMem ENDP

4
MdePkg/Library/BaseMemoryLibSse2/SetMem16Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem16 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/BaseMemoryLibSse2/SetMem32Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem32 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/BaseMemoryLibSse2/SetMem64Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem64 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/PeiMemoryLib/SetMem16Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem16 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/PeiMemoryLib/SetMem32Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem32 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/PeiMemoryLib/SetMem64Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem64 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/UefiMemoryLib/SetMem16Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem16 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/UefiMemoryLib/SetMem32Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem32 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;

4
MdePkg/Library/UefiMemoryLib/SetMem64Wrapper.c
View File

@ -54,8 +54,8 @@ SetMem64 (
{ {
ASSERT (Buffer != NULL); ASSERT (Buffer != NULL);
ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1); ASSERT (Length <= MAX_ADDRESS - (UINTN)Buffer + 1);
ASSERT ((((UINTN)Buffer) & 1) != 0); ASSERT ((((UINTN)Buffer) & (sizeof (Value) - 1)) != 0);
ASSERT ((Length & 1) != 0); ASSERT ((Length & (sizeof (Value) - 1)) != 0);
if ((Length /= sizeof (Value)) == 0) { if ((Length /= sizeof (Value)) == 0) {
return Buffer; return Buffer;