tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-23 21:54:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

OvmfPkg/PlatformPei: Verification: stop using mPlatformInfoHob

Browse Source 
Stop using the mPlatformInfoHob global variable in S3Verification() and
Q35BoardVerification() functions.  Pass a pointer to the PlatformInfoHob
instead.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Tom Lendacky <thomas.lendacky@amd.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
This commit is contained in:
Gerd Hoffmann 2022-12-02 14:10:04 +01:00 committed by mergify[bot]
parent 7dbb8a24d1
commit 4bc2c74851
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
OvmfPkg/PlatformPei/Platform.c
View File

@ -231,13 +231,14 @@ ReserveEmuVariableNvStore (
ASSERT_RETURN_ERROR (PcdStatus); ASSERT_RETURN_ERROR (PcdStatus);
} }
STATIC
VOID VOID
S3Verification ( S3Verification (
VOID IN EFI_HOB_PLATFORM_INFO *PlatformInfoHob
) )
{ {
#if defined (MDE_CPU_X64) #if defined (MDE_CPU_X64)
if (mPlatformInfoHob.SmmSmramRequire && mPlatformInfoHob.S3Supported) { if (PlatformInfoHob->SmmSmramRequire && PlatformInfoHob->S3Supported) {
DEBUG (( DEBUG ((
DEBUG_ERROR, DEBUG_ERROR,
"%a: S3Resume2Pei doesn't support X64 PEI + SMM yet.\n", "%a: S3Resume2Pei doesn't support X64 PEI + SMM yet.\n",
@ -260,12 +261,13 @@ S3Verification (
#endif #endif
} }
STATIC
VOID VOID
Q35BoardVerification ( Q35BoardVerification (
VOID IN EFI_HOB_PLATFORM_INFO *PlatformInfoHob
) )
{ {
if (mPlatformInfoHob.HostBridgeDevId == INTEL_Q35_MCH_DEVICE_ID) { if (PlatformInfoHob->HostBridgeDevId == INTEL_Q35_MCH_DEVICE_ID) {
return; return;
} }
@ -274,7 +276,7 @@ Q35BoardVerification (
"%a: no TSEG (SMRAM) on host bridge DID=0x%04x; " "%a: no TSEG (SMRAM) on host bridge DID=0x%04x; "
"only DID=0x%04x (Q35) is supported\n", "only DID=0x%04x (Q35) is supported\n",
__FUNCTION__, __FUNCTION__,
mPlatformInfoHob.HostBridgeDevId, PlatformInfoHob->HostBridgeDevId,
INTEL_Q35_MCH_DEVICE_ID INTEL_Q35_MCH_DEVICE_ID
)); ));
ASSERT (FALSE); ASSERT (FALSE);
@ -345,7 +347,7 @@ InitializePlatform (
ASSERT_EFI_ERROR (Status); ASSERT_EFI_ERROR (Status);
} }
S3Verification (); S3Verification (&mPlatformInfoHob);
BootModeInitialization (&mPlatformInfoHob); BootModeInitialization (&mPlatformInfoHob);
// //
@ -357,7 +359,7 @@ InitializePlatform (
MaxCpuCountInitialization (&mPlatformInfoHob); MaxCpuCountInitialization (&mPlatformInfoHob);
if (mPlatformInfoHob.SmmSmramRequire) { if (mPlatformInfoHob.SmmSmramRequire) {
Q35BoardVerification (); Q35BoardVerification (&mPlatformInfoHob);
Q35TsegMbytesInitialization (&mPlatformInfoHob); Q35TsegMbytesInitialization (&mPlatformInfoHob);
Q35SmramAtDefaultSmbaseInitialization (&mPlatformInfoHob); Q35SmramAtDefaultSmbaseInitialization (&mPlatformInfoHob);
} }