From 4bf3b994e8b207fc919958b4a212a8342aaaa749 Mon Sep 17 00:00:00 2001 From: Jeff Westfahl Date: Thu, 27 Apr 2017 03:59:29 +0800 Subject: [PATCH] ShellPkg/ShellCommandLib: Update DumpHex to print {|}~ ASCII characters {|}~ should be printed by DumpHex. The problem is that if you have a string like {xizzy}~{foo|bar}~{quux} in the dumped data, it will not appear as such in the *-delimited ASCII column to the right, but as .xizzy...foo.bar...quux. which is less than ideal. Most of the commit message was inspired by/shamelessly stolen from Laszlo's example: https://lists.01.org/pipermail/edk2-devel/2017-April/010266.html Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Westfahl Reviewed-by: Laszlo Ersek Reviewed-by: Ruiyu Ni --- ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c index a2ebc8f820..bd14878052 100644 --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c @@ -1745,7 +1745,7 @@ DumpHex ( Val[Index * 3 + 0] = Hex[TempByte >> 4]; Val[Index * 3 + 1] = Hex[TempByte & 0xF]; Val[Index * 3 + 2] = (CHAR8) ((Index == 7) ? '-' : ' '); - Str[Index] = (CHAR8) ((TempByte < ' ' || TempByte > 'z') ? '.' : TempByte); + Str[Index] = (CHAR8) ((TempByte < ' ' || TempByte > '~') ? '.' : TempByte); } Val[Index * 3] = 0;